🐛 fix V2 hangs on GET - #272
Open
sebastianMindee wants to merge 2 commits into
Open
sebastianMindee wants to merge 2 commits into
sebastianMindee wants to merge 2 commits into
Conversation
sebastianMindee
requested review from
ianardee
and
a balanced review from Copilot
September 28, 2026 15:12
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A regression test is needed to prevent the hanging GET behavior from returning.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes V2 GET requests hanging while adding connection timeout handling.
Changes:
- Removes chunked transfer encoding from V2 GET requests.
- Applies open and read timeouts and updates Net::HTTP typing.
| File | Description |
|---|---|
lib/mindee/v2/http/mindee_api_v2.rb |
Corrects GET headers and configures HTTP timeouts. |
sig/custom/net_http.rbs |
Adds open_timeout to the HTTP signature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -145,9 +146,11 @@ def poll(url) | |||
| 'User-Agent' => @settings.user_agent, | |||
| } | |||
| req = Net::HTTP::Get.new(uri, headers) | |||
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #271
Types of changes