Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/mindee/v2/http/mindee_api_v2.rb
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,11 @@ def req_get_search(params)
'User-Agent' => @settings.user_agent,
}
req = Net::HTTP::Get.new(uri, headers)
req['Transfer-Encoding'] = 'chunked'

response = Net::HTTP.start(uri.hostname, uri.port,
use_ssl: true, read_timeout: @settings.request_timeout) do |http|
use_ssl: true,
open_timeout: @settings.request_timeout,
read_timeout: @settings.request_timeout) do |http|
http.request(req)
end
params.response_class.new(process_response(response))
Expand Down Expand Up @@ -145,9 +146,11 @@ def poll(url)
'User-Agent' => @settings.user_agent,
}
req = Net::HTTP::Get.new(uri, headers)
Comment thread
sebastianMindee marked this conversation as resolved.
req['Transfer-Encoding'] = 'chunked'

Net::HTTP.start(uri.hostname, uri.port, use_ssl: true, read_timeout: @settings.request_timeout) do |http|
Net::HTTP.start(uri.hostname, uri.port,
use_ssl: true,
open_timeout: @settings.request_timeout,
read_timeout: @settings.request_timeout) do |http|
return http.request(req)
end
raise Mindee::Error::MindeeError, 'Could not resolve server response.'
Expand Down Expand Up @@ -208,7 +211,10 @@ def enqueue(input_source, params)
req.set_form(form_data, 'multipart/form-data')
req['Transfer-Encoding'] = 'chunked'

Net::HTTP.start(uri.hostname, uri.port, use_ssl: true, read_timeout: @settings.request_timeout) do |http|
Net::HTTP.start(uri.hostname, uri.port,
use_ssl: true,
open_timeout: @settings.request_timeout,
read_timeout: @settings.request_timeout) do |http|
return http.request(req)
end
raise Mindee::Error::MindeeError, 'Could not resolve server response.'
Expand Down
2 changes: 1 addition & 1 deletion sig/custom/net_http.rbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Net
class BufferedIO
end
class HTTP
def self.start: [T] (String?, Integer?, use_ssl: bool?, ?read_timeout: Integer) { (HTTP) -> T } -> T
def self.start: [T] (String?, Integer?, use_ssl: bool?, ?open_timeout: Integer, ?read_timeout: Integer) { (HTTP) -> T } -> T

def request: (untyped) -> untyped

Expand Down
2 changes: 1 addition & 1 deletion spec/data
23 changes: 23 additions & 0 deletions spec/v2/client_v2_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,29 @@ def stub_next_request_with(method, hash:, status_code: 0)
resp.job.completed_at.strftime('%Y-%m-%dT%H:%M:%S.%6N')
).to eq('2026-04-20T18:32:02.734312')
end
it 'poll builds a real Net::HTTP::Get request without a Transfer-Encoding header' do
job_json = File.read(File.join(V2_DATA_DIR, 'job', 'ok_processing.json'))
captured_request = nil
captured_options = nil

http_double = instance_double(Net::HTTP)
allow(http_double).to receive(:request) do |req|
captured_request = req
build_mock_http_response(job_json, 200)
end
allow(Net::HTTP).to receive(:start) do |_host, _port, **options, &block|
captured_options = options
block.call(http_double)
end

api.send(:poll, "#{base_url}/v2/jobs/123e4567-e89b-12d3-a456-426614174000")

expect(captured_request).to be_a(Net::HTTP::Get)
expect(captured_request['Transfer-Encoding']).to be_nil
expect(captured_options[:open_timeout]).to eq(api.settings.request_timeout)
expect(captured_options[:read_timeout]).to eq(api.settings.request_timeout)
end

context 'Cancellation token' do
let(:processing_json) { File.read(File.join(V2_DATA_DIR, 'job', 'ok_processing.json')) }

Expand Down
Loading