Drop this run's test database when the job ends, instead of two days later - #681
Merged
Conversation
…later Same omission as home_care_billing PR 1138. Nothing dropped these; infra-ci-db-reap swept them on a 2-day retention, which made a backstop into the primary mechanism - 440 live databases on the CI instance on 2026-08-12, each waiting up to two days for a sweep that only exists because this step did not. The reaper stays, because a cancelled or killed job never reaches its own cleanup step. One drop covers the run: Repo, AdminRepo and HeavyReadRepo all resolve to the same loopctl_test plus MIX_TEST_PARTITION name. if always() because a failed suite strands a database exactly like a passing one, and best-effort so a cleanup problem cannot turn a green run red. The only existing DROP in this workflow is for the scale-test database, which runs on a hosted runner against a service container and was never the one accumulating here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same omission as home_care_billing#1138.
Nothing dropped these.
infra-ci-db-reapswept them on a 2-day retention, which made a backstop into the primary mechanism — 440 live databases on the shared CI instance on 2026-08-12, each waiting up to two days for a sweep that only exists because this step did not. There was never a rationale for keeping them; it was an omission.The reaper stays: a cancelled or killed job never reaches its own cleanup step, so end-of-job dropping cannot be the only mechanism. Backstop second, not first.
Repo,AdminRepoandHeavyReadRepoall resolve toloopctl_test${MIX_TEST_PARTITION}.if: always()— a failed suite strands a database exactly like a passing one.PGPORTis already job-scoped to 5433, the CI-only instance.The only existing
DROPin this workflow is for the scale-test database, which runs on a hosted runner against a service container — never the one accumulating here.Reviewed inline (this session cannot dispatch agents/workflows) per the CLAUDE.md gate clause.