Conversation
When the keepalive failure threshold is reached, startKeepalive logs "keepalive ping failed; closing session" at Error. In practice this is almost always a client that went away, the normal end of a session, so on a long-running server these records drown out real errors. Log it at Warn, the same level as the below-threshold case and as a failed notification delivery in notifySessions. Fixes modelcontextprotocol#1281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1281
When the keepalive failure threshold is reached,
startKeepalivelogs "keepalive ping failed; closing session" at Error. In practice this is almost always a client that went away, the normal end of a session, so on a long-running server these records drown out real errors (the issue has numbers: 1281 of 1285 Error records over 23 days).This logs it at Warn, the same level as the below-threshold case right above it and as a failed notification delivery in
notifySessions.TestKeepAliveFailure_Loggednow captures at Warn and checks the level; it fails without the change.go vet ./...andgo test -race ./...pass.