Skip to content

mcp: log a keepalive session close at Warn, not Error #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oplatonov wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

mcp: log a keepalive session close at Warn, not Error #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mcp/mcp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,7 @@ func TestKeepAliveFailure_Logged(t *testing.T) {
var buf bytes.Buffer
clientOpts := &ClientOptions{
KeepAlive: 50 * time.Millisecond,
Logger: slog.New(slog.NewTextHandler(&buf, &slog.HandlerOptions{Level: slog.LevelError})),
Logger: slog.New(slog.NewTextHandler(&buf, &slog.HandlerOptions{Level: slog.LevelWarn})),
}
c := NewClient(testImpl, clientOpts)
// Pin to 2025-11-25: KeepAlive uses the ping RPC, which is removed
Expand All @@ -1992,8 +1992,8 @@ func TestKeepAliveFailure_Logged(t *testing.T) {
synctest.Wait()

got := buf.String() // slog serializes Write calls internally
if !strings.Contains(got, "keepalive ping failed") {
t.Errorf("expected keepalive failure to be logged, got log output:\n%s", got)
if !strings.Contains(got, `level=WARN msg="keepalive ping failed; closing session"`) {
t.Errorf("expected keepalive failure to be logged at Warn, got log output:\n%s", got)
}
})
}
Expand Down
2 changes: 1 addition & 1 deletion mcp/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ func startKeepalive(session keepaliveSession, interval time.Duration, failureThr
}
// Threshold reached; log before closing the session so the
// failure is observable to operators. See #218.
logger.Error("keepalive ping failed; closing session",
logger.Warn("keepalive ping failed; closing session",
"error", err,
"consecutiveFailures", consecutiveFailures,
"failureThreshold", failureThreshold)
Expand Down