Repository navigation
Add Qwen3-TTS data and forward-loss contracts (1/4) - #350
Open
Wallbreazzz wants to merge 2 commits into
Open
Wallbreazzz wants to merge 2 commits into
Wallbreazzz wants to merge 2 commits into
Conversation
This was referenced Oct 28, 2026
Wallbreazzz
marked this pull request as ready for review
October 28, 2026 15:11
Author
|
@tastelikefeet 感谢此前在 RFC #279 中帮忙梳理方案,#350 已 ready,方便时请优先帮忙检视这一层的数据与前向/loss契约。验证方面,本层 CPU 契约 8 项通过、2 项官方依赖检查在隔离模式下跳过,完整训练树已通过单昇腾 NPU 的 40 项测试,拆分后的最终 Git tree 与该验收版本完全一致。后续 LoRA 接入、恢复、训练 CLI 已准备好,将在前置 PR 合入后依次提交并吸收您的意见,希望先尽快对齐这一层的接口,减少后续返工。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and scope
This first dependency layer adds Qwen3-TTS 12Hz tensor preparation, two-stage forward/loss contracts and CPU tests for local single-Ascend-NPU bf16 LoRA. It is part of RFC #279 and does not close it. Model loading, the training CLI and generation are later layers; no Twinkle core or default dependency changes are included.
The residual Code Predictor must receive the Talker state that predicted the current frame's first codebook, before that frame was consumed. Selecting the hidden state at the target frame exposes its target codebook embeddings during training but not generation. The corrected selection uses the preceding position. Talker still applies its own temporal label shift; residual-codebook heads retain matching per-head labels without an extra codebook-axis shift.
A behavioral regression changes the current frame's residual codes and verifies that its conditioning is unchanged while the following frame's conditioning changes. It fails on the previous implementation. Earlier gradient/update/reload tests did not establish this causal equivalence.
Validation
python tests/batch1/test_contracts.py --isolated-twinklefrom the cookbook. Infrastructure doubles are not native Twinkle/NPU validation.791b488subsequently passed 8 targeted contracts and real paired generation on the same single-NPU environment; both decoded waveforms matched the previously reviewed pair sample for sample. This is a targeted packaging/default-language check, not a rerun of the complete NPU training suite.Contribution sequence
The active dependent fork branches include this correction. Later upstream PRs follow prerequisite merges. The closed monolithic draft #349 and its old branch remain historical references and are not the corrected delivery candidate. CUDA, MOSS, multi-card and concurrent multi-LoRA are outside the validated scope.