Conversation
…dex/integration-0.64-kimi
…o codex/integration-0.64-kimi
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thermo-nuclear code-quality reviewVerdict: PASS — no actionable maintainability findings. The change tightens the existing Kimi cookie policy into an explicit allowlist and keeps the provider-specific default in the settings accessor that already owns provider defaults. Tests cover automatic, manual, off, case-insensitive, and authoritative-manual behavior. The diff adds no new abstraction layer, scattered branching, meaningful duplication, or file-size threshold crossing. |
|
Thermo source closeout: PASS at Valid manual credentials are selected alone. When those credentials are absent or invalid, automatic desktop/browser discovery is gated on This PR now targets |
Ports upstream v0.64.0 Kimi cookie-source behavior (
dc2e01ea9). Manual and Off sources now remain authoritative when the configured token is empty or invalid, so they no longer fall through to Kimi Desktop or browser credential discovery. Explicit valid manual tokens continue to win.This PR targets the temporary Kimi integration base containing prerequisite PRs #586 and #587. It does not merge those prerequisites into
main.Validation:
cargo test --manifest-path rust/Cargo.toml providers::kimi::web::tests --lib(9 passed)cargo clippy --manifest-path rust/Cargo.toml --lib --tests -- -D warningscargo fmt --allgit diff --check