Conversation
…dex/integration-0.64-kimi
…o codex/integration-0.64-kimi
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thermo-nuclear code-quality reviewVerdict: FINDINGS Medium — centralize settings-aware dashboard resolution
The Kimi region-to-console URL decision is implemented independently in provider-detail construction and dashboard opening. MiniMax already has the same duplication, and adding Kimi grows parallel provider-specific condition chains that can drift: the UI can advertise one URL while the command opens another. Please extract one settings-aware dashboard resolver taking The new |
|
Applied the two test corrections already reviewed, validated in CircleCI, and merged in #607. They remove the shared tray-layout timing failure and unrelated Claude fixture-startup timeout; the current head is The earlier thermo finding about duplicated regional dashboard resolution is addressed: provider detail and dashboard opening now use the shared |
|
Thermo source closeout: PASS at One typed The recorded fresh Windows/CUA proof shows the region picker with CircleCI passes at this head. This PR now targets |
Ports the Windows-relevant Kimi regional routing from upstream v0.64.1 (
7618b4fdd,a0feb78fd,1caaeb883). Settings can now select China (kimi.com, default) or International (kimi.ai), and the Code API, web membership calls, browser/Desktop cookie lookup, dashboard URL, and request Origin/Referer move together. Unscoped Kimi Code CLI credentials remain China-only because their credential file does not identify an issuing host.This PR is stacked on #598, whose base contains prerequisite PRs #586 and #587.
Validation:
cargo test --manifest-path rust/Cargo.toml providers::kimi --lib(55 passed)cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml kimi_region(2 passed)cargo clippy --manifest-path rust/Cargo.toml --lib --tests -- -D warningscargo clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkpnpm --dir apps/desktop-tauri run tauri:build:debugCODEXBAR_PROOF_MODE=settings:providers; the live Region combobox renderedChina (kimi.com). Screenshot:C:\Users\mac\AppData\Local\Temp\wcb-kimi-region-selected.png.