Stabilize tray layout and Claude login tests in CI

[Finesssee]

CircleCI intermittently failed unchanged tray-layout and Claude login tests when the Windows runner was busy. The tray test now restarts its quiet window after its single permitted delayed reveal. The login exit-status test waits for its controlled fixture processes before checking their completed results, so shell startup time cannot trigger an unrelated ten-second timeout.

The failed-login assertion checks the exit-code error specifically. The separate running-child cancellation and timeout test remains. Application behavior is unchanged.

Validation on this update:

• pnpm --dir apps/desktop-tauri test -- src/hooks/useTrayPanelLayout.sizing.test.tsx: 3 passed.
• cargo test --manifest-path rust/Cargo.toml --lib providers::claude::accounts::login::tests -- --test-threads=4: 14 passed on Windows.
• cargo fmt --all --check and git diff --check: passed.
• Independent thermo review: no test-validity or structure blockers.
• Full backend/Tauri checks and clippy are delegated to the required CircleCI Windows gate for the updated commit; this avoids another large local build cache.

Summary by CodeRabbit

• Tests
  • Improved the reliability of automated checks for desktop panel sizing and account login, including clearer verification of timing and process exit behavior.
  • No user-facing functionality changed.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8b380aba-433b-4633-b5c6-50f654d0b4c1

📥 Commits

Reviewing files that changed from the base of the PR and between 4c909c4 and b345e09.

📒 Files selected for processing (1)

• rust/src/providers/claude/accounts/login.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The tray panel sizing test now polls for a stable reveal count. The Claude login test reaps child processes before checking login results and verifies the failed child’s exit code and error message.

Changes

Tray panel sizing test

Layer / File(s)	Summary
Poll for reveal-count stability apps/desktop-tauri/src/hooks/useTrayPanelLayout.sizing.test.tsx	The test tracks reveal-count changes and checks that the count remains stable for at least 500 ms, polling every 50 ms with a 3-second timeout.

Claude login test

Layer / File(s)	Summary
Reap children and verify login results rust/src/providers/claude/accounts/login.rs	The test waits for each child process before calling wait_for_login with Duration::ZERO. The failed case checks for exit code Some(1) and an error message containing "exit code 1".

Priority: ⚪ Not assessed

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b345e

The changes tighten test checks without an established merge-blocking risk. The updated tests can be merged with normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main changes: stabilizing the tray layout and Claude login tests in CI.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Finesssee]

Thermo review and CI failure follow-up

Independent review of the combined tray-sizing and Claude-login test changes found no blocking structure or test-validity issue.

• The sizing test still permits at most one delayed reveal overall and requires a 500 ms quiet period, so repeated auto-fit feedback remains a failure.
• The login test checks successful isolated credentials and the exact failed-process exit error. Fixture startup no longer consumes an arbitrary ten-second login deadline; the separate cancellation/timeout test still exercises a running child.
• No runtime code, dependencies, abstractions, or production timing changed.

Current local verification: the 3 sizing tests and 14 Claude login tests pass on Windows; Rust formatting and diff checks pass. The updated commit still requires the full hosted Windows check before merge.