Repository navigation
feat(pages): add the grid canvas and its widgets #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a74c604
feat(pages): add the grid canvas and its widgets
rubenvdlinde b9bae63
fix(pages): show a widget the same in view and edit mode, with its ti…
rubenvdlinde 1e7a9dc
feat(pages): show the tables widget and the theme colors of a header
rubenvdlinde 57f49f5
fix(pages): apply a layout to the grid in one load and keep GridStack…
rubenvdlinde e68e977
fix(pages): send the source of every widget without looking up its type
rubenvdlinde 3a92d93
fix(pages): make a data widget load once, fit its card and handle eve…
rubenvdlinde 70707d2
fix(pages): name each widget menu, keep focus on a step and drop dupl…
rubenvdlinde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
| import { h } from 'vue' | ||
| import GridCanvas from '../../src/modules/grid/GridCanvas.vue' | ||
|
|
||
| const layout = [ | ||
| { widgetId: 'w1', gridX: 0, gridY: 0, gridWidth: 12, gridHeight: 2 }, | ||
| { widgetId: 'w2', gridX: 0, gridY: 2, gridWidth: 6, gridHeight: 3 }, | ||
| ] | ||
|
|
||
| /** | ||
| * @param {object} props props of the canvas | ||
| */ | ||
| function mountCanvas(props) { | ||
| cy.mount(GridCanvas, { | ||
| props, | ||
| slots: { widget: ({ item }) => h('span', { 'data-cy': 'slotWidget' }, item.widgetId) }, | ||
| }).then(({ wrapper }) => cy.wrap(wrapper).as('wrapper')) | ||
| } | ||
|
|
||
| describe('GridCanvas', () => { | ||
| it('places every widget of the layout where it is stored', () => { | ||
| cy.viewport(1400, 800) | ||
| mountCanvas({ layout, editable: false }) | ||
|
|
||
| cy.get('[data-cy="gridItem"]').should('have.length', 2) | ||
| cy.get('[data-cy="gridItem"][gs-id="w2"]').should('have.attr', 'gs-w', '6') | ||
| cy.get('[data-cy="slotWidget"]').first().should('have.text', 'w1') | ||
| cy.get('.grid-canvas--editing').should('not.exist') | ||
| }) | ||
|
|
||
| it('can be arranged in edit mode on a wide screen', () => { | ||
| cy.viewport(1400, 800) | ||
| mountCanvas({ layout, editable: true }) | ||
|
|
||
| cy.get('.grid-canvas--editing').should('exist') | ||
| cy.get('[data-cy="gridNarrowHint"]').should('not.exist') | ||
| }) | ||
|
|
||
| it('is only shown, not arranged, on a narrow screen', () => { | ||
| cy.viewport(420, 800) | ||
| mountCanvas({ layout, editable: true }) | ||
|
|
||
| cy.get('[data-cy="gridNarrowHint"]').should('be.visible') | ||
| cy.get('.grid-canvas--editing').should('not.exist') | ||
| }) | ||
|
|
||
| it('adds a widget that appears in the layout', () => { | ||
| cy.viewport(1400, 800) | ||
| mountCanvas({ layout, editable: true }) | ||
|
|
||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ layout: [...layout, { widgetId: 'w3', gridX: 6, gridY: 2, gridWidth: 6, gridHeight: 3 }] })) | ||
| cy.get('[data-cy="gridItem"]').should('have.length', 3) | ||
| cy.get('@wrapper').should(wrapper => { | ||
| expect(wrapper.vm.grid.engine.nodes.map(node => node.id)).to.include('w3') | ||
| }) | ||
| }) | ||
|
|
||
| it('keeps the animation GridStack sets on its root when edit mode toggles', () => { | ||
| cy.viewport(1400, 800) | ||
| mountCanvas({ layout, editable: false }) | ||
|
|
||
| cy.get('.grid-stack').should('have.class', 'grid-stack-animate') | ||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ editable: true })) | ||
| cy.get('.grid-canvas--editing').should('exist') | ||
| cy.get('.grid-stack').should('have.class', 'grid-stack-animate') | ||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ editable: false })) | ||
| cy.get('.grid-canvas--editing').should('not.exist') | ||
| cy.get('.grid-stack').should('have.class', 'grid-stack-animate') | ||
| }) | ||
|
|
||
| it('does not animate when the user asks for reduced motion', () => { | ||
| cy.viewport(1400, 800) | ||
| cy.window().then(win => { | ||
| const matchMedia = win.matchMedia.bind(win) | ||
| cy.stub(win, 'matchMedia').callsFake(query => query === '(prefers-reduced-motion: reduce)' ? { matches: true, media: query, addEventListener() {}, removeEventListener() {} } : matchMedia(query)) | ||
| }) | ||
| mountCanvas({ layout, editable: false }) | ||
|
|
||
| cy.get('[data-cy="gridItem"]').should('have.length', 2) | ||
| cy.get('.grid-stack').should('not.have.class', 'grid-stack-animate') | ||
| }) | ||
|
|
||
| it('mirrors the grid in a right-to-left language', () => { | ||
| cy.viewport(1400, 800) | ||
| const language = globalThis._nc_l10n_language | ||
| globalThis._nc_l10n_language = 'ar' | ||
| mountCanvas({ layout, editable: false }) | ||
|
|
||
| cy.get('.grid-stack').should('have.class', 'grid-stack-rtl') | ||
| cy.then(() => { | ||
| globalThis._nc_l10n_language = language | ||
| }) | ||
| }) | ||
|
|
||
| it('moves a widget from the menu next to its neighbour without sending it below the others', () => { | ||
| cy.viewport(1400, 800) | ||
| const sideBySide = [ | ||
| { widgetId: 'w1', gridX: 0, gridY: 0, gridWidth: 12, gridHeight: 2 }, | ||
| { widgetId: 'w2', gridX: 0, gridY: 2, gridWidth: 6, gridHeight: 3 }, | ||
| { widgetId: 'w3', gridX: 6, gridY: 2, gridWidth: 6, gridHeight: 3 }, | ||
| { widgetId: 'w4', gridX: 0, gridY: 5, gridWidth: 12, gridHeight: 4 }, | ||
| ] | ||
| mountCanvas({ layout: sideBySide, editable: true }) | ||
|
|
||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ layout: sideBySide.map(item => item.widgetId === 'w2' ? { ...item, gridX: 1 } : item) })) | ||
| cy.get('@wrapper').should(wrapper => { | ||
| const moved = wrapper.vm.grid.engine.nodes.find(node => node.id === 'w2') | ||
| expect(moved.x).to.equal(1) | ||
| expect(moved.y).to.equal(2) | ||
| }) | ||
| // GridStack pushed the neighbour to make room, and the page gets told where it went | ||
| cy.get('@wrapper').should(wrapper => { | ||
| const emitted = wrapper.emitted('layout-change') | ||
| expect(emitted).to.have.length(1) | ||
| const settled = emitted[0][0] | ||
| expect(settled.find(item => item.widgetId === 'w2')).to.include({ gridX: 1, gridY: 2 }) | ||
| const neighbour = settled.find(item => item.widgetId === 'w3') | ||
| const engineNeighbour = wrapper.vm.grid.engine.nodes.find(node => node.id === 'w3') | ||
| expect(neighbour).to.include({ gridX: engineNeighbour.x, gridY: engineNeighbour.y }) | ||
| }) | ||
| }) | ||
|
|
||
| it('shows the stored layout again when the canvas widens, also after it changed while narrow', () => { | ||
| cy.viewport(800, 800) | ||
| mountCanvas({ layout, editable: false }) | ||
| cy.get('.grid-stack').should('have.class', 'gs-6') | ||
|
|
||
| const changed = [ | ||
| { widgetId: 'w1', gridX: 0, gridY: 0, gridWidth: 12, gridHeight: 2 }, | ||
| { widgetId: 'w2', gridX: 6, gridY: 4, gridWidth: 4, gridHeight: 2 }, | ||
| ] | ||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ layout: changed })) | ||
| cy.viewport(1400, 800) | ||
| cy.get('.grid-stack').should('have.class', 'gs-12') | ||
| cy.get('@wrapper').should(wrapper => { | ||
| const node = wrapper.vm.grid.engine.nodes.find(node => node.id === 'w2') | ||
| expect({ x: node.x, y: node.y, w: node.w, h: node.h }).to.deep.equal({ x: 6, y: 4, w: 4, h: 2 }) | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,250 @@ | ||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
| import { h } from 'vue' | ||
| import { subscribe, unsubscribe } from '@nextcloud/event-bus' | ||
| import GridWidget from '../../src/modules/grid/GridWidget.vue' | ||
| import DataWidget from '../../src/modules/grid/widgets/DataWidget.vue' | ||
| import TableWrapper from '../../src/modules/main/sections/TableWrapper.vue' | ||
| import { useTablesStore } from '../../src/store/store.js' | ||
|
|
||
| const nodes = { | ||
| 4: { id: 4, node_type: 0, node_id: 40, permissions: 1 }, | ||
| 5: { id: 5, node_type: 1, node_id: 50, permissions: 1 }, | ||
| } | ||
|
|
||
| const table = { id: 40, title: 'Tasks', emoji: '✅', ownership: 'admin', ownerDisplayName: 'admin', isShared: false, onSharePermissions: null, sort: [] } | ||
| const view = { id: 50, tableId: 40, title: 'Open', emoji: '📌', ownership: 'admin', ownerDisplayName: 'admin', isShared: false, onSharePermissions: null, filter: [], sort: [{ columnId: 1, mode: 'DESC' }], columns: [1], columnSettings: [{ columnId: 1, order: 0 }] } | ||
| const columns = [{ id: 1, tableId: 40, title: 'Name', type: 'text', subtype: 'line', mandatory: false, description: '', textDefault: '', textAllowedPattern: '', textMaxLength: -1, textUnique: false, selectionOptions: [], selectionDefault: '', datetimeDefault: '' }] | ||
| const rows = [{ id: 7, tableId: 40, createdBy: 'admin', createdAt: '2026-01-01 10:00:00', lastEditBy: 'admin', lastEditAt: '2026-01-01 10:00:00', data: [{ columnId: 1, value: 'Write the plan' }] }] | ||
|
|
||
| /** | ||
| * Answers the requests of a data widget for the table and the view with one column and one row, | ||
| * and puts both in the store, so the widget renders its table. | ||
| */ | ||
| function stubData() { | ||
| cy.intercept('GET', '**/apps/tables/api/1/tables/40/columns', columns).as('tableColumns') | ||
| cy.intercept('GET', '**/apps/tables/row/table/40', rows).as('tableRows') | ||
| cy.intercept('GET', '**/apps/tables/api/1/tables/40/relations', {}) | ||
| cy.intercept('GET', '**/apps/tables/api/1/views/50/columns', columns).as('viewColumns') | ||
| cy.intercept('GET', '**/apps/tables/row/view/50', rows).as('viewRows') | ||
| cy.intercept('GET', '**/apps/tables/api/1/views/50/relations', {}) | ||
| cy.then(() => { | ||
| const store = useTablesStore() | ||
| store.tables = [{ ...table }] | ||
| store.views = [{ ...view }] | ||
| }) | ||
| } | ||
|
|
||
| /** | ||
| * @param {object} widget the widget to show | ||
| * @param {boolean} editable whether the page is edited | ||
| * @param {object|null} layoutItem where the widget sits | ||
| */ | ||
| function mountWidget(widget, editable, layoutItem = null) { | ||
| cy.intercept('GET', '**/apps/tables/api/2/widget-types', { ocs: { data: [] } }) | ||
| cy.mount(GridWidget, { props: { widget, nodes, editable, layoutItem } }).then(({ wrapper }) => cy.wrap(wrapper).as('wrapper')) | ||
| } | ||
|
|
||
| describe('GridWidget', () => { | ||
| it('shows the title, icon and description of a widget', () => { | ||
| mountWidget({ key: 'w1', id: 1, type: 'header', title: 'Welcome', icon: 'star', description: 'What we agreed', settings: { heading: 'Projects', subheading: 'This quarter', textAlign: 'end' }, nodeRelId: null }, false) | ||
|
|
||
| cy.get('[data-cy="gridWidget"] h2').should('contain.text', 'Welcome') | ||
| cy.get('[data-cy="gridWidget"] h2 svg').should('exist') | ||
| cy.get('[data-cy="gridWidgetDescription"]').should('have.text', 'What we agreed') | ||
| cy.get('.header-widget').should('contain.text', 'Projects').and('contain.text', 'This quarter').and('have.css', 'text-align', 'end') | ||
| }) | ||
|
|
||
| it('shows no heading for a widget without a title, also in edit mode, where its menu floats', () => { | ||
| mountWidget({ key: 'w2', id: 2, type: 'text', title: '', settings: { text: 'First\n\nSecond' }, nodeRelId: null }, false) | ||
|
|
||
| cy.get('[data-cy="gridWidget"] h2').should('not.exist') | ||
| cy.get('.text-widget__paragraph').should('have.length', 2) | ||
|
|
||
| mountWidget({ key: 'w2', id: 2, type: 'text', title: '', settings: { text: 'First' }, nodeRelId: null }, true) | ||
| cy.get('[data-cy="gridWidget"] h2').should('not.exist') | ||
| cy.get('.grid-widget__header--floating button[aria-label="Actions for text"]').should('be.visible') | ||
| }) | ||
|
|
||
| it('is a region labelled by its heading only when it has a title', () => { | ||
| mountWidget({ key: 'w2', id: 2, type: 'text', title: '', settings: { text: 'First' }, nodeRelId: null }, false) | ||
| cy.get('div[data-cy="gridWidget"]').should('not.have.attr', 'aria-label') | ||
| cy.get('section[data-cy="gridWidget"]').should('not.exist') | ||
|
|
||
| mountWidget({ key: 'w11', id: 11, type: 'text', title: 'Notes', settings: { text: 'First' }, nodeRelId: null }, false) | ||
| cy.get('section[data-cy="gridWidget"]').should('have.attr', 'aria-labelledby', 'grid-widget-title-w11') | ||
| cy.get('#grid-widget-title-w11').should('contain.text', 'Notes') | ||
| }) | ||
|
|
||
| it('titles a data widget without a title after its table, which then shows no title of its own', () => { | ||
| stubData() | ||
| mountWidget({ key: 'w5', id: 5, type: 'data', title: '', settings: {}, nodeRelId: 4 }, false) | ||
|
|
||
| cy.get('[data-cy="gridWidget"] h2').should('contain.text', '✅ Tasks') | ||
| cy.get('[data-cy="gridWidget"] table').should('contain.text', 'Write the plan') | ||
| cy.get('[data-cy="gridWidget"] h1').should('not.exist') | ||
| // Without the title row, the sticky options of the table sit at the top of the widget | ||
| cy.get('[data-cy="gridWidget"] .options.row').should('have.css', 'top', '0px') | ||
| }) | ||
|
|
||
| it('loads the table of a data widget once, also when edit mode toggles', () => { | ||
| stubData() | ||
| mountWidget({ key: 'w5', id: 5, type: 'data', title: '', settings: {}, nodeRelId: 4 }, false) | ||
| cy.get('[data-cy="gridWidget"] table').should('contain.text', 'Write the plan') | ||
|
|
||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ editable: true })) | ||
| cy.get('[data-cy="gridWidget"] button[aria-haspopup]').should('exist') | ||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ editable: false })) | ||
| cy.get('[data-cy="gridWidget"] table').should('contain.text', 'Write the plan') | ||
| cy.get('@tableColumns.all').should('have.length', 1) | ||
| cy.get('@tableRows.all').should('have.length', 1) | ||
| }) | ||
|
|
||
| it('starts a view in its saved sorting, reloads it when the view changes and starts over on another target', () => { | ||
| stubData() | ||
| mountWidget({ key: 'w10', id: 10, type: 'data', title: '', settings: {}, nodeRelId: 5 }, false) | ||
| cy.get('[data-cy="gridWidget"] table').should('contain.text', 'Write the plan') | ||
| cy.get('@wrapper').should(wrapper => { | ||
| expect(wrapper.findComponent(DataWidget).vm.viewSetting).to.deep.equal({ presetSorting: [{ columnId: 1, mode: 'DESC' }] }) | ||
| }) | ||
|
|
||
| // As the view settings dialog does after saving a new filter | ||
| cy.then(() => { | ||
| const store = useTablesStore() | ||
| store.views = store.views.map(item => item.id === 50 ? { ...item, filter: [[{ columnId: 1, operator: 'contains', value: 'plan' }]] } : item) | ||
| }) | ||
| cy.get('@viewRows.all').should('have.length', 2) | ||
| cy.get('@viewColumns.all').should('have.length', 2) | ||
|
|
||
| cy.get('@wrapper').then(wrapper => wrapper.setProps({ widget: { ...wrapper.props('widget'), nodeRelId: 4 } })) | ||
| cy.get('[data-cy="gridWidget"] table').should('contain.text', 'Write the plan') | ||
| cy.get('@wrapper').should(wrapper => { | ||
| expect(wrapper.findComponent(DataWidget).vm.viewSetting).to.deep.equal({}) | ||
| }) | ||
| }) | ||
|
|
||
| it('opens the sharing and integration tabs of the sidebar for the table of a data widget', () => { | ||
| stubData() | ||
| const opened = [] | ||
| const onOpen = data => opened.push(data) | ||
| subscribe('tables:sidebar:sharing', onOpen) | ||
| subscribe('tables:sidebar:integration', onOpen) | ||
| mountWidget({ key: 'w5', id: 5, type: 'data', title: '', settings: {}, nodeRelId: 4 }, false) | ||
| cy.get('[data-cy="gridWidget"] table').should('exist') | ||
|
|
||
| cy.get('@wrapper').then(wrapper => { | ||
| wrapper.findComponent(TableWrapper).vm.$emit('toggle-share') | ||
| wrapper.findComponent(TableWrapper).vm.$emit('show-integration') | ||
| }) | ||
| cy.then(() => { | ||
| expect(opened).to.deep.equal([{ open: true, tab: 'sharing' }, { open: true, tab: 'integration' }]) | ||
| expect(useTablesStore().activeTableId).to.equal(40) | ||
| unsubscribe('tables:sidebar:sharing', onOpen) | ||
| unsubscribe('tables:sidebar:integration', onOpen) | ||
| }) | ||
| }) | ||
|
|
||
| it('fits the table of a data widget into the widget instead of the app content', () => { | ||
| cy.viewport(1400, 800) | ||
| stubData() | ||
| cy.intercept('GET', '**/apps/tables/api/2/widget-types', { ocs: { data: [] } }) | ||
| cy.then(() => document.documentElement.style.setProperty('--app-content-width', '1400px')) | ||
| const widget = { key: 'w5', id: 5, type: 'data', title: '', settings: {}, nodeRelId: 4 } | ||
| cy.mount({ render: () => h('div', { style: 'width: 600px; height: 500px' }, [h(GridWidget, { widget, nodes, editable: false })]) }) | ||
|
|
||
| cy.get('[data-cy="gridWidget"] table').should('exist') | ||
| cy.get('.data-widget').then(([dataWidget]) => { | ||
| cy.get('.data-widget .options.row').invoke('width').should('be.at.most', dataWidget.clientWidth) | ||
| }) | ||
| cy.then(() => document.documentElement.style.removeProperty('--app-content-width')) | ||
| }) | ||
|
|
||
| it('keeps the line breaks of a widget description', () => { | ||
| mountWidget({ key: 'w12', id: 12, type: 'text', title: 'Notes', description: 'First line\nSecond line', settings: { text: '' }, nodeRelId: null }, false) | ||
| cy.get('[data-cy="gridWidgetDescription"]').should('have.css', 'white-space', 'pre-wrap') | ||
| }) | ||
|
|
||
| it('gives the heading of a header the text color of its color pair', () => { | ||
| mountWidget({ key: 'w6', id: 6, type: 'header', title: '', settings: { heading: 'Due today', color: 'primary' }, nodeRelId: null }, false) | ||
| cy.get('.header-widget').then(([header]) => { | ||
| cy.get('.header-widget__title').should('have.css', 'color', getComputedStyle(header).color) | ||
| }) | ||
| }) | ||
|
|
||
| it('colors a header with a color pair of the theme, and falls back to primary', () => { | ||
| mountWidget({ key: 'w6', id: 6, type: 'header', title: '', settings: { heading: 'Due today', color: 'warning' }, nodeRelId: null }, false) | ||
| cy.get('.header-widget').should('have.class', 'header-widget--warning') | ||
|
|
||
| mountWidget({ key: 'w7', id: 7, type: 'header', title: '', settings: { heading: 'Projects', color: '#ff0000' }, nodeRelId: null }, false) | ||
| cy.get('.header-widget').should('have.class', 'header-widget--primary') | ||
| }) | ||
|
|
||
| it('shows every table and view of the application in a tables widget', () => { | ||
| cy.intercept('GET', '**/apps/tables/**', { statusCode: 404, body: {} }) | ||
| cy.intercept('GET', '**/apps/tables/api/2/widget-types', { ocs: { data: [] } }) | ||
| const applicationNodes = { 4: nodes[4], 5: { id: 5, node_type: 1, node_id: 50, permissions: 1 }, 6: { id: 6, node_type: 9, node_id: 60, permissions: 1 } } | ||
| cy.mount(GridWidget, { props: { widget: { key: 'w8', id: 8, type: 'tables', title: '', settings: {}, nodeRelId: null }, nodes: applicationNodes, editable: false } }) | ||
|
|
||
| cy.get('[data-cy="tablesWidget"] .data-widget').should('have.length', 2) | ||
| }) | ||
|
|
||
| it('shows an empty state in a tables widget of an application without tables', () => { | ||
| cy.intercept('GET', '**/apps/tables/api/2/widget-types', { ocs: { data: [] } }) | ||
| cy.mount(GridWidget, { props: { widget: { key: 'w9', id: 9, type: 'tables', title: '', settings: {}, nodeRelId: null }, nodes: {}, editable: false } }) | ||
| cy.get('[data-cy="tablesWidgetEmpty"]').should('contain.text', 'No tables or views yet') | ||
| }) | ||
|
|
||
| it('asks editors to pick a table or view for a data widget without one, and shows viewers an empty state', () => { | ||
| mountWidget({ key: 'w3', id: 3, type: 'data', title: '', settings: {}, nodeRelId: 9 }, true) | ||
| cy.get('[data-cy="dataWidgetPickSource"]').should('be.visible') | ||
| cy.get('[data-cy="dataWidgetNoSource"]').should('not.exist') | ||
|
|
||
| mountWidget({ key: 'w4', id: 4, type: 'data', title: 'Tasks', settings: {}, nodeRelId: null }, false) | ||
| cy.get('[data-cy="dataWidgetNoSource"]').should('contain.text', 'No table or view to show') | ||
| cy.get('[data-cy="dataWidgetPickSource"]').should('not.exist') | ||
| }) | ||
|
|
||
| it('moves and resizes a widget from its menu, so the grid can be arranged with a keyboard', () => { | ||
| mountWidget({ key: 'w6', id: 6, type: 'text', title: 'Notes', settings: { text: '' }, nodeRelId: null }, true, { widgetId: 'w6', gridX: 0, gridY: 0, gridWidth: 6, gridHeight: 2 }) | ||
|
|
||
| cy.get('[data-cy="gridWidget"] button[aria-label="Actions for Notes"]').click() | ||
| cy.get('[data-cy="widgetMoveLeft"]').should('have.class', 'action--disabled') | ||
| cy.get('[data-cy="widgetMoveRight"] button').click() | ||
| cy.get('@wrapper').then(wrapper => { | ||
| expect(wrapper.emitted('move')[0][1]).to.deep.equal({ gridX: 1 }) | ||
| }) | ||
| }) | ||
|
|
||
| it('keeps focus on a step from the menu and reads out where the widget went', () => { | ||
| mountWidget({ key: 'w6', id: 6, type: 'text', title: 'Notes', settings: { text: '' }, nodeRelId: null }, true, { widgetId: 'w6', gridX: 2, gridY: 1, gridWidth: 6, gridHeight: 2 }) | ||
|
|
||
| cy.get('[data-cy="gridWidget"] button[aria-label="Actions for Notes"]').click() | ||
| // The menu focuses its first action once it is open | ||
| cy.focused().should('contain.text', 'Remove widget') | ||
| cy.get('[data-cy="widgetNarrower"] button').focus() | ||
| cy.focused().type('{enter}') | ||
| cy.get('@wrapper').then(wrapper => { | ||
| expect(wrapper.emitted('move')[0][1]).to.deep.equal({ gridWidth: -1 }) | ||
| wrapper.setProps({ layoutItem: { widgetId: 'w6', gridX: 2, gridY: 1, gridWidth: 5, gridHeight: 2 } }) | ||
| }) | ||
| cy.get('[data-cy="gridWidgetAnnouncement"]').should('have.attr', 'aria-live', 'polite') | ||
| .and('contain.text', 'Column 3, row 2, 5 columns wide and 2 rows high') | ||
| cy.focused().should('contain.text', 'Make narrower') | ||
| }) | ||
|
|
||
| it('swaps moving left and right in a right-to-left language', () => { | ||
| const language = globalThis._nc_l10n_language | ||
| globalThis._nc_l10n_language = 'ar' | ||
| mountWidget({ key: 'w6', id: 6, type: 'text', title: 'Notes', settings: { text: '' }, nodeRelId: null }, true, { widgetId: 'w6', gridX: 0, gridY: 0, gridWidth: 6, gridHeight: 2 }) | ||
|
|
||
| cy.get('[data-cy="gridWidget"] button[aria-label="Actions for Notes"]').click() | ||
| cy.get('[data-cy="widgetMoveRight"]').should('have.class', 'action--disabled') | ||
| cy.get('[data-cy="widgetMoveLeft"] button').click() | ||
| cy.get('@wrapper').then(wrapper => { | ||
| expect(wrapper.emitted('move')[0][1]).to.deep.equal({ gridX: 1 }) | ||
| globalThis._nc_l10n_language = language | ||
| }) | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes before the table has rendered, so it can't catch the title coming back. Waiting for the table first (for example
cy.get('[data-cy="gridWidget"] table').should('exist')) makes it meaningful.Validated: code check only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, with the 404 the table never rendered. The test now stubs the columns and rows, waits for the row to show up in the table, and only then checks there's no second title.
cc @blizzz