ffi: validate DynamicLibrary getter receivers - #65288
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65288 +/- ##
==========================================
- Coverage 90.32% 90.32% -0.01%
==========================================
Files 751 751
Lines 250000 249972 -28
Branches 47231 47227 -4
==========================================
- Hits 225816 225784 -32
- Misses 15566 15569 +3
- Partials 8618 8619 +1
🚀 New features to boost your workflow:
|
Check the receivers of the path, symbols, and functions getters before unwrapping them. This prevents incompatible receivers from crashing the process and makes the getters throw ERR_INVALID_THIS instead. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
fix-ffi-getter-crash
branch
from
August 14, 2026 16:58
29be2a9 to
5768e16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65287
Check the receivers of the path, symbols, and functions getters before unwrapping them. This prevents incompatible receivers from crashing the process and makes the getters throw ERR_INVALID_THIS instead.
Assisted-by: codex:gpt-5.6-sol