Skip to content

ffi: validate DynamicLibrary getter receivers #65288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −0
Open

ffi: validate DynamicLibrary getter receivers #65288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/node_ffi.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,15 @@ void DynamicLibrary::InvokeCallback(ffi_cif* cif,
}

void DynamicLibrary::GetPath(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
if (!GetConstructorTemplate(env)->HasInstance(args.This())) {
THROW_ERR_INVALID_THIS(env,
"Value of \"this\" must be of type DynamicLibrary");
return;
}

DynamicLibrary* lib = Unwrap<DynamicLibrary>(args.This());
CHECK_NOT_NULL(lib);

Local<Value> path;
if (!ToV8Value(lib->env()->context(), lib->path_, args.GetIsolate())
Expand Down Expand Up @@ -806,9 +814,16 @@ void DynamicLibrary::GetFunction(const FunctionCallbackInfo<Value>& args) {

void DynamicLibrary::GetFunctions(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
if (!GetConstructorTemplate(env)->HasInstance(args.This())) {
THROW_ERR_INVALID_THIS(env,
"Value of \"this\" must be of type DynamicLibrary");
return;
}

Isolate* isolate = env->isolate();
Local<Context> context = env->context();
DynamicLibrary* lib = Unwrap<DynamicLibrary>(args.This());
CHECK_NOT_NULL(lib);

if (lib->is_closed()) {
THROW_ERR_FFI_LIBRARY_CLOSED(env);
Expand Down Expand Up @@ -955,9 +970,16 @@ void DynamicLibrary::GetSymbol(const FunctionCallbackInfo<Value>& args) {

void DynamicLibrary::GetSymbols(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
if (!GetConstructorTemplate(env)->HasInstance(args.This())) {
THROW_ERR_INVALID_THIS(env,
"Value of \"this\" must be of type DynamicLibrary");
return;
}

Isolate* isolate = env->isolate();
Local<Context> context = env->context();
DynamicLibrary* lib = Unwrap<DynamicLibrary>(args.This());
CHECK_NOT_NULL(lib);

if (lib->is_closed()) {
THROW_ERR_FFI_LIBRARY_CLOSED(env);
Expand Down
19 changes: 19 additions & 0 deletions test/ffi/test-ffi-dynamic-library.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,25 @@ test('DynamicLibrary exposes functions and symbols', () => {
}
});

test('DynamicLibrary getters reject incompatible receivers', () => {
const lib = new ffi.DynamicLibrary(libraryPath);

try {
const getters = [
Object.getOwnPropertyDescriptor(lib, 'path').get,
Object.getOwnPropertyDescriptor(lib, 'symbols').get,
Object.getOwnPropertyDescriptor(
ffi.DynamicLibrary.prototype, 'functions').get,
];

for (const getter of getters) {
assert.throws(() => getter.call({}), { code: 'ERR_INVALID_THIS' });
}
} finally {
lib.close();
}
});

test('DynamicLibrary evaluates function signatures once', () => {
function makeChangingSignature() {
const reads = { arguments: 0, return: 0 };
Expand Down
Loading