Repository navigation
2026-11-16, Version 27.0.0-alpha.0.1.1 (Alpha) - #67515
Draft
github-actions[bot] wants to merge 24 commits into
Draft
github-actions[bot] wants to merge 24 commits into
github-actions[bot] wants to merge 24 commits into
Conversation
Original commit message:
[heap] Always decrement age in RetainMaps()
When the prototype and constructor were already marked we did not
age the map because of the assumption that this would only keep the
transition tree alive. However, this does not hold because of
the JSFunctions inside an AccessorPair in DescriptorArray.
This can result in retaining maps indefinitely when not triggering
memory reducing GCs. This CL therefore simplifies the code to
always age maps instead. This is neutral on Speedometer and Jetstream.
Bug: 571157135
Change-Id: I8fb633a0ec0c1d66e4596390ca48e1c7006c9cc2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8557820
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110622}
Refs: v8/v8@497c2e6
PR-URL: #66728
Reviewed-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Original commit message:
[heap] Treat zero allocation throughput as a low allocation rate
Since https://crrev.com/c/5935313 allocation throughput is tracked with
SmoothedBytesAndDuration, which has no lower bound. A sampled throughput
of exactly 0 -- nothing was allocated, or the smoothed value decayed to
0 after a long idle period -- made ComputeMutatorUtilizationImpl()
return a mutator utilization of 0 ("maximal allocation"). For an isolate
that never allocates on the CppHeap, HasLowAllocationRate() is then
never true and the MemoryReducer cannot start a GC through its
low-allocation condition; only the 100s watchdog can. Node.js hits this
for any process that does not use node:vm.
Remove the special case. A mutator speed of 0 now yields a mutator
utilization of 1, i.e. the lowest possible allocation rate. gc_speed is
either the conservative default or at least 1 byte/ms, so the formula
stays well defined.
Bug: 570738027
Change-Id: I84cd51607df3c31c2f1e02bb2fe258e5506131ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8521518
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110599}
Refs: v8/v8@2444c10
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #66736
PR-URL: #67333 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
Document that `this` is bound to the `tls.TLSSocket` instance when `SNICallback` and `ALPNCallback` are invoked. Signed-off-by: Robert I Nilsson <robert.i.nilsson@callclue.com> PR-URL: #66682 Reviewed-By: Tim Perry <pimterry@gmail.com>
Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: #67379 Reviewed-By: Philipp Dunkel <pip@pipobscure.com> Reviewed-By: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Treats warnings as errors, so we can detect regressions. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #67380 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
The "exports" field type lists `string[]`, but the packages documentation never describes how an array of targets is resolved. Document that items are tried in order, that only invalid targets and unmatched conditions are skipped, and that a missing file does not cause the next item to be tried. Fixes: #58600 Signed-off-by: Manjeet Singh <024manjeetsingh@gmail.com> PR-URL: #67393 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
The subtest watched all of tmpdir, so files created there by the subtests running alongside it restarted the child and broke its output. The fix is to watch a directory of its own instead to not conflict. Refs: #66232 Assisted-by: Claude Signed-off-by: Farid Zakaria <farid.m.zakaria@gmail.com> PR-URL: #67041 Reviewed-By: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Adds the facility to ignore root certificates by fingerprint using mk-ca-bundle's -x parameter. Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #67403 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
When a certificate's notBefore or notAfter time cannot be parsed, validFrom and validTo return the string 'Bad time value', and validFromDate and validToDate return an invalid Date. Relational comparisons with an invalid Date are always false, so a naive expiry check can treat such a certificate as valid. Document the current behavior and tell callers to reject invalid dates first. Signed-off-by: Sarthak Ahuja <39986642+SarthakAhuja@users.noreply.github.com> PR-URL: #67406 Refs: #67285 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
Some test cases made a single change right after creating a watcher. On macOS, libuv starts the FSEvents stream asynchronously, so that change could be missed and the test hung until it timed out. Keep making the change until the watcher reports it, as the other cases in the file already do. Refs: nodejs/reliability#1715 Refs: nodejs/reliability#1644 Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: #67298 Refs: https://github.com/nodejs/node/actions/runs/42177414954 Reviewed-By: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
Original commit message:
[temporal] Compute zoneinfo64.res length from ResB index table
ICU4C's offsetTOCLookupFn sets UDataMemory::length = -1 for the last
entry in a .dat archive (which occurs for zoneinfo64.res in small-icu
builds where zu.res is excluded), and pointerTOCLookupFn sets length = -1
for all entries in pointer TOC builds.
When UDataMemory::length is -1, compute the bundle byte length from the
ResB header offset (udata_getMemory(memory) - data) and the
self-describing URES_INDEX_BUNDLE_TOP word in the ResB index table,
matching ICU4C's res_init() in uresdata.cpp. Also check USING_SYSTEM_ICU
in addition to V8_ENABLE_TEMPORAL_SYSTEMICU when deciding whether
internal udatamem.h is available.
Bug: 576986967
Change-Id: I7a2c881eb3891a97eafb244f71aa405ff2434b51
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8642579
Commit-Queue: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#111181}
Refs: v8/v8@a051772
Co-authored-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #67416
Refs: https://issues.chromium.org/issues/576986967
Refs: #62676
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
A JavaScript number is always bound with sqlite3_bind_double(), so it is written as REAL even when it has no fractional part. A BigInt is bound with sqlite3_bind_int64() and is the way to write an INTEGER. The type conversion table listed number under both INTEGER and REAL without saying which applies when, so the rule had to be discovered by experiment. Column type affinity hides this most of the time, which is why the cases it does not cover are surprising. Comparing against a TEXT column is the worst of them: the number 3 compares as '3.0' and silently fails to match a stored '3', with no error to point at the cause. Document the rule, the reason for it, and that case, and remove number from the table's INTEGER row. Point the virtual table section's link at the new text. better-sqlite3 binds numbers the same way and has fielded the same question repeatedly (WiseLibs/better-sqlite3#165, #627, #897, #1144, #1313), each time closed as working as intended. Fixes: #63826 Refs: WiseLibs/better-sqlite3#627 Assisted-by: Claude Opus 5.5 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com> PR-URL: #67424 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guilherme Araújo <arauujogui@gmail.com>
Assisted-by: Claude Opus 5.5 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com> PR-URL: #67425 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #67434 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The pbkdf2() call that keeps the only threadpool worker busy used a 6-byte password and a 4-byte salt. OpenSSL 4 FIPS rejects those, so the derivation failed at once and freed the worker. The queued stat could then start before req.cancel() ran, and it completed without ECANCELED. Use inputs that meet the FIPS minimums and check that the derivation succeeds. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> PR-URL: #67449 Refs: #67248 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The PSK server's pskCallback answered every identity, but OpenSSL also asks it about the resumption ticket, cut at its first NUL byte. When that prefix is valid UTF-8, about 1% of the time, the ticket was taken for an external PSK and the handshake failed with decrypt_error. Only answer for the identity the client sends. Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> PR-URL: #67450 Refs: nodejs/reliability#1722 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
Signed-off-by: LiviaMedeiros <livia@cirno.name> PR-URL: #67343 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
The binary tarball target only codesigns bin/node. Notarization runs only for the pkg, and tools/osx-notarize.sh only knows how to submit a pkg, so every darwin tarball binary ships signed but without a ticket. Gatekeeper then applies a full trust evaluation to each process spawned through it, which slows down every CLI shim on macOS. Make tools/osx-notarize.sh take a path instead of a version id. A .pkg keeps the existing flow. Any other file is treated as a Mach-O binary: it is zipped with ditto, submitted with notarytool, and the ticket is verified with `codesign --verify -R=notarized` using the existing retry helper. spctl cannot be used for that check, it rejects command line tools as "not an app". The binary itself is not modified, so published checksums do not change. A bare version id is still accepted and resolved to node-<version>.pkg for the release branches. Call the script from the binary target after codesign. It is a no-op unless the NOTARIZATION_* variables are exported, so the tarball jobs keep behaving as today until the release job injects them. Refs: #67140 Refs: nodejs/build#3538 Refs: nodejs/build#4545 Refs: #66855 Assisted-by: Claude Assisted-by: Codex Signed-off-by: Ulises Gascon <ulisesgascongonzalez@gmail.com> PR-URL: #67143 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Ultroncn <82553854+Ultroncn@users.noreply.github.com> PR-URL: #67463 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #67108 Reviewed-By: James M Snell <jasnell@gmail.com>
Do not include the vendored simdutf when compiling merve if shared simdutf is used to ensure the headers match the linked library. Signed-off-by: Yao Zi <me@ziyao.cc> PR-URL: #67410 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added a commit
that referenced
this pull request
Nov 16, 2026
Notable changes: PR-URL: #67515
Collaborator
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
force-pushed
the
v27.0.0-alpha.0.1.1-proposal
branch
from
November 16, 2026 10:24
2310a33 to
6c7c893
Compare
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/79169/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aa0572bada] - build: do not include vendored simdutf with--shared-simdutf(Yao Zi) #67410a5672e8023] - build: enable pie on linux (Chengzhong Wu) #67386cfb550171d] - deps: V8: backport a05177279022 (René) #67416a92ee337b1] - deps: update nghttp3 to 1.19.0 (Node.js GitHub Bot) #67333f775f92e2e] - deps: V8: backport 2444c109f4f8 (Austin Burdine) #66736a4787636cb] - deps: V8: cherry-pick 497c2e6a2434 (Dominik Inführ) #667287c6dd81da3] - doc: fix typo in releases.md (Ultron) #674639fda0620f2] - doc: add aduh95 as last security release stewards (Antoine du Hamel) #67434a23a18b8e5] - doc: explain how sqlite binds numbers and BigInts (Trevor Burnham) #67424136ae6f518] - doc: document invalid X509Certificate validity times (Sarthak Ahuja) #67406e396cb0bb3] - doc: explain fallback arrays in package exports targets (Manjeet Singh) #673933c930d22ea] - doc: documentthisbinding in TLS callbacks (Robert I Nilsson) #666821a1489838c] - meta: update Trevor Burnham's email in.mailmap(Trevor Burnham) #6742517be7f1efc] - test: use relative paths within test directory intest-watch-mode.mjs(Livia Medeiros) #673435d51de3db7] - test: deflake test-tls-resume-servername (Christian Aurich Zanettini Martins) #67450e3caf971c1] - test: deflake test-fs-stat-cancel-inflight under FIPS (Christian Aurich Zanettini Martins) #67449098b4788ca] - test: deflake test-watch-mode-files_watcher (Yuya Inoue) #67298b2f17a3732] - test: deflake watch mode test for missing env file (Farid Zakaria) #670415aac327abd] - test: increase iterations on histogram test after snapshot changes (Stewart X Addison) #6737970d8236efe] - tools: add support for multiple-commit PRs inreview_backport.sh(Antoine du Hamel) #67108e0c71bcd1c] - tools: notarize bin/node in the darwin tarballs (Ulises Gascón) #6714367d57cfef1] - tools: update mk-ca-bundle to 1.35 (René) #674038dfdbb540e] - tools: enable strict mode for yamllint (Antoine du Hamel) #67380