Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a478763
deps: V8: cherry-pick 497c2e6a2434
Oct 12, 2026
f775f92
deps: V8: backport 2444c109f4f8
acburdine Oct 8, 2026
a92ee33
deps: update nghttp3 to 1.19.0
nodejs-github-bot Nov 11, 2026
3c930d2
doc: document `this` binding in TLS callbacks
bobnil Oct 12, 2026
5aac327
test: increase iterations on histogram test after snapshot changes
sxa Nov 12, 2026
8dfdbb5
tools: enable strict mode for yamllint
aduh95 Nov 12, 2026
e396cb0
doc: explain fallback arrays in package exports targets
manusingh090 Nov 12, 2026
b2f17a3
test: deflake watch mode test for missing env file
fzakaria Oct 26, 2026
67d57cf
tools: update mk-ca-bundle to 1.35
Renegade334 Nov 13, 2026
136ae6f
doc: document invalid X509Certificate validity times
SarthakAhuja Nov 13, 2026
098b478
test: deflake test-watch-mode-files_watcher
inoway46 Nov 13, 2026
cfb5501
deps: V8: backport a05177279022
Renegade334 Nov 13, 2026
a23a18b
doc: explain how sqlite binds numbers and BigInts
TrevorBurnham Nov 14, 2026
1a14898
meta: update Trevor Burnham's email in `.mailmap`
TrevorBurnham Nov 14, 2026
9fda062
doc: add aduh95 as last security release stewards
aduh95 Nov 14, 2026
e3caf97
test: deflake test-fs-stat-cancel-inflight under FIPS
christianaurichzm Nov 15, 2026
5d51de3
test: deflake test-tls-resume-servername
christianaurichzm Nov 15, 2026
17be7f1
test: use relative paths within test directory in `test-watch-mode.mjs`
LiviaMedeiros Nov 15, 2026
e0c71bc
tools: notarize bin/node in the darwin tarballs
UlisesGascon Nov 15, 2026
a5672e8
build: enable pie on linux
legendecas Nov 15, 2026
7c6dd81
doc: fix typo in releases.md
Ultroncn Nov 16, 2026
70d8236
tools: add support for multiple-commit PRs in `review_backport.sh`
aduh95 Nov 16, 2026
aa0572b
build: do not include vendored simdutf with `--shared-simdutf`
ziyao233 Nov 16, 2026
6c7c893
2026-11-16, Version 27.0.0-alpha.0.1.1 (Alpha)
nodejs-github-bot Nov 16, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nix-changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 2
persist-credentials: true # We need read access in case we need to fetch in `Compute requisites before change` step
persist-credentials: true # We need read access in case we need to fetch in `Compute requisites before change` step
sparse-checkout: |
shell.nix
tools/nix/
Expand Down
2 changes: 1 addition & 1 deletion .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ Tomoki Okahana <umatomakun@gmail.com>
Toon Verwaest <verwaest@chromium.org>
Tracy Hinds <tracyhinds@gmail.com>
Travis Meisenheimer <travis@indexoutofbounds.com> <tmeisenh@gmail.com>
Trevor Burnham <trevor@databraid.com> <trevorburnham@gmail.com>
Trevor Burnham <trevorburnham@gmail.com> <trevor@databraid.com>
Trivikram Kamat <trivikr.dev@gmail.com> <16024985+trivikr@users.noreply.github.com>
ttzztztz <ttzztztz@outlook.com> <yangziyue80@outlook.com>
Tyler Larson <talltyler@gmail.com>
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V27.md#27.0.0-alpha.0.1.0">27.0.0-alpha.0.1.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V27.md#27.0.0-alpha.0.1.1">27.0.0-alpha.0.1.1</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V27.md#27.0.0-alpha.0.1.0">27.0.0-alpha.0.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V27.md#27.0.0-alpha.0.0.0">27.0.0-alpha.0.0.0</a><br/>
</td>
<td valign="top">
Expand Down
7 changes: 5 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,7 @@ $(PKG): release-only
--resources $(MACOSOUTDIR)/installer/productbuild/Resources \
--package-path $(MACOSOUTDIR)/pkgs ./$(PKG)
SIGN="$(PRODUCTSIGN_CERT)" PKG="$(PKG)" sh tools/osx-productsign.sh
sh tools/osx-notarize.sh $(FULLVERSION)
sh tools/osx-notarize.sh $(PKG)

.PHONY: pkg
pkg: $(PKG) ## Build the macOS installer for releases.
Expand Down Expand Up @@ -1433,6 +1433,7 @@ else
endif
ifeq ($(OSTYPE),darwin)
SIGN="$(CODESIGN_CERT)" PKGDIR="$(BINARYNAME)" sh tools/osx-codesign.sh
sh tools/osx-notarize.sh $(BINARYNAME)/bin/node
endif
tar -cf $(BINARYNAME).tar $(BINARYNAME)
$(RM) -r $(BINARYNAME)
Expand Down Expand Up @@ -1715,15 +1716,17 @@ endif
# python -m pip install yamllint
# Try with '--system' if it fails without; the system may have set '--user'
lint-yaml-build: ## Build resources needed to lint YAML files.
ifeq ($(YAMLLINT), tools/pip/site-packages/bin/yamllint)
$(info Pip installing yamllint on $(shell $(PYTHON) --version)...)
$(PYTHON) -m pip install --upgrade -t tools/pip/site-packages yamllint || \
$(PYTHON) -m pip install --upgrade --system -t tools/pip/site-packages yamllint
endif

.PHONY: lint-yaml
ifneq ("","$(wildcard $(YAMLLINT))")
lint-yaml: ## Lint the YAML files with yamllint.
$(info Running YAML linter...)
PYTHONPATH=tools/pip $(YAMLLINT) .
PYTHONPATH=tools/pip $(YAMLLINT) --strict .
else
lint-yaml:
$(warning YAML linting with yamllint is not available)
Expand Down
19 changes: 18 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.14',

##### V8 defaults for Node.js #####

Expand Down Expand Up @@ -699,6 +699,23 @@
'cflags': [ '-fPIC' ],
'ldflags': [ '-fPIC' ],
}],
# Link executables as PIE so that ASLR randomizes the executable
# image too. Every object in a PIE must be built with `-fPIC` or
# `-fPIE`. PIE flags should not apply to shared library objects,
# like addons. `--fully-static` uses `-static-pie`, see configure.py.
[ 'OS=="linux" and configuring_node', {
'target_conditions': [
['_type=="executable"', {
'ldflags': [ '-pie' ],
}],
],
'conditions': [
# Use `-fPIE` unless the condition above uses `-fPIC`.
[ 'node_shared!="true" and node_enable_v8debughelper!="true"', {
'cflags': [ '-fPIE' ],
}],
],
}],
],
}],
[ 'OS in "aix os400"', {
Expand Down
7 changes: 6 additions & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -2538,7 +2538,12 @@ def configure_static(o):
return

if options.fully_static:
o['libraries'] += ['-static']
if flavor == 'linux':
# `-static` drops the `-pie` from common.gypi, e.g. clang:
# https://github.com/llvm/llvm-project/blob/68b03cf380e61c86aa59f94a10e8ce2d4c10cbb0/clang/lib/Driver/ToolChains/Gnu.cpp#L351-L366
o['libraries'] += ['-static-pie']
else:
o['libraries'] += ['-static']
elif options.partly_static:
o['libraries'] += ['-static-libgcc', '-static-libstdc++']
if options.enable_asan:
Expand Down
6 changes: 5 additions & 1 deletion deps/merve/merve.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
'type': 'static_library',
'include_dirs': [
'.',
'../v8/third_party/simdutf',
],
'direct_dependent_settings': {
'include_dirs': ['.'],
Expand All @@ -29,6 +28,11 @@
'CLANG_CXX_LANGUAGE_STANDARD': 'c++20',
},
}],
['node_shared_simdutf=="false"', {
'include_dirs': [
'../v8/third_party/simdutf',
],
}],
],
},
]
Expand Down
21 changes: 15 additions & 6 deletions deps/ngtcp2/nghttp3/lib/includes/nghttp3/nghttp3.h
Original file line number Diff line number Diff line change
Expand Up @@ -1871,12 +1871,13 @@ typedef struct nghttp3_settings {
NGHTTP3_SETTINGS_V3. */
/**
* :member:`glitch_ratelim_burst` is the maximum number of tokens
* available to "glitch" rate limiter. "glitch" is a suspicious
* activity from a remote endpoint. If detected, certain amount of
* tokens are consumed. If no tokens are available to consume, the
* connection is closed. The rate of token generation is specified
* by :member:`glitch_ratelim_rate`. This feature is enabled only
* when `nghttp3_conn_read_stream2` is used.
* available to "glitch" rate limiter. It is clamped to UINT64_MAX
* / NGHTTP3_SECONDS. "glitch" is a suspicious activity from a
* remote endpoint. If detected, certain amount of tokens are
* consumed. If no tokens are available to consume, the connection
* is closed. The rate of token generation is specified by
* :member:`glitch_ratelim_rate`. This feature is enabled only when
* `nghttp3_conn_read_stream2` is used.
*
* .. version-added:: 1.12.0
*/
Expand Down Expand Up @@ -3089,6 +3090,8 @@ typedef struct nghttp3_data_reader {
* Stream has already been opened.
* :macro:`NGHTTP3_ERR_NOMEM`
* Out of memory.
* :macro:`NGHTTP3_ERR_INVALID_ARGUMENT`
* The required memory for |nva| of length |nvlen| is too large.
*/
NGHTTP3_EXTERN int nghttp3_conn_submit_request(
nghttp3_conn *conn, int64_t stream_id, const nghttp3_nv *nva, size_t nvlen,
Expand All @@ -3108,6 +3111,8 @@ NGHTTP3_EXTERN int nghttp3_conn_submit_request(
* Stream not found
* :macro:`NGHTTP3_ERR_NOMEM`
* Out of memory.
* :macro:`NGHTTP3_ERR_INVALID_ARGUMENT`
* The required memory for |nva| of length |nvlen| is too large.
*/
NGHTTP3_EXTERN int nghttp3_conn_submit_info(nghttp3_conn *conn,
int64_t stream_id,
Expand All @@ -3130,6 +3135,8 @@ NGHTTP3_EXTERN int nghttp3_conn_submit_info(nghttp3_conn *conn,
* Stream not found
* :macro:`NGHTTP3_ERR_NOMEM`
* Out of memory.
* :macro:`NGHTTP3_ERR_INVALID_ARGUMENT`
* The required memory for |nva| of length |nvlen| is too large.
*/
NGHTTP3_EXTERN int nghttp3_conn_submit_response(nghttp3_conn *conn,
int64_t stream_id,
Expand All @@ -3154,6 +3161,8 @@ NGHTTP3_EXTERN int nghttp3_conn_submit_response(nghttp3_conn *conn,
* Application has already submitted fin to stream.
* :macro:`NGHTTP3_ERR_NOMEM`
* Out of memory.
* :macro:`NGHTTP3_ERR_INVALID_ARGUMENT`
* The required memory for |nva| of length |nvlen| is too large.
*/
NGHTTP3_EXTERN int nghttp3_conn_submit_trailers(nghttp3_conn *conn,
int64_t stream_id,
Expand Down
4 changes: 2 additions & 2 deletions deps/ngtcp2/nghttp3/lib/includes/nghttp3/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
*
* Version number of the nghttp3 library release.
*/
#define NGHTTP3_VERSION "1.18.0"
#define NGHTTP3_VERSION "1.19.0"

/**
* @macro
Expand All @@ -41,6 +41,6 @@
* number, 8 bits for minor and 8 bits for patch. Version 1.2.3
* becomes 0x010203.
*/
#define NGHTTP3_VERSION_NUM 0x011200
#define NGHTTP3_VERSION_NUM 0x011300

#endif /* !defined(NGHTTP3_VERSION_H) */
2 changes: 1 addition & 1 deletion deps/ngtcp2/nghttp3/lib/nghttp3_balloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ int nghttp3_balloc_get(nghttp3_balloc *balloc, void **pbuf, size_t n) {

if (nghttp3_buf_left(&balloc->buf) < n) {
p = nghttp3_mem_malloc(balloc->mem,
sizeof(nghttp3_memblock_hd) + 0x8U + balloc->blklen);
sizeof(nghttp3_memblock_hd) + 0xFU + balloc->blklen);
if (p == NULL) {
return NGHTTP3_ERR_NOMEM;
}
Expand Down
12 changes: 7 additions & 5 deletions deps/ngtcp2/nghttp3/lib/nghttp3_buf.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@
*/
#include "nghttp3_buf.h"

void nghttp3_buf_init(nghttp3_buf *buf) {
buf->begin = buf->end = buf->pos = buf->last = NULL;
}
void nghttp3_buf_init(nghttp3_buf *buf) { *buf = (nghttp3_buf){0}; }

void nghttp3_buf_wrap_init(nghttp3_buf *buf, uint8_t *src, size_t len) {
buf->begin = buf->pos = buf->last = src;
buf->end = buf->begin + len;
*buf = (nghttp3_buf){
.begin = src,
.end = src + len,
.pos = src,
.last = src,
};
}

void nghttp3_buf_free(nghttp3_buf *buf, const nghttp3_mem *mem) {
Expand Down
44 changes: 28 additions & 16 deletions deps/ngtcp2/nghttp3/lib/nghttp3_conn.c
Original file line number Diff line number Diff line change
Expand Up @@ -555,13 +555,14 @@ nghttp3_ssize nghttp3_conn_read_stream2(nghttp3_conn *conn, int64_t stream_id,
return 0;
}

if (fin) {
stream->flags |= NGHTTP3_STREAM_FLAG_READ_EOF;
}

if (nghttp3_stream_uni(stream_id)) {
return nghttp3_conn_read_uni(conn, stream, src, srclen, fin, ts);
}

if (fin) {
stream->flags |= NGHTTP3_STREAM_FLAG_READ_EOF;
}
return nghttp3_conn_read_bidi(conn, &bidi_nproc, stream, src, srclen, fin,
ts);
}
Expand Down Expand Up @@ -1126,6 +1127,13 @@ nghttp3_ssize nghttp3_conn_read_control(nghttp3_conn *conn,
break;
}

/* Apply buffer limits here even if everything is in the input
buffer. */
if (rstate->left > sizeof(conn->rx.pri_fieldbuf)) {
rstate->state = NGHTTP3_CTRL_STREAM_STATE_IGN_FRAME;
break;
}

conn->rx.pri_fieldbuflen = 0;

rstate->state = NGHTTP3_CTRL_STREAM_STATE_PRIORITY_UPDATE;
Expand All @@ -1141,22 +1149,12 @@ nghttp3_ssize nghttp3_conn_read_control(nghttp3_conn *conn,
len = (size_t)nghttp3_min(rstate->left, (uint64_t)(end - p));
assert(len > 0);
if (conn->rx.pri_fieldbuflen == 0 && rstate->left == len) {
/* Everything is in the input buffer. Apply same length
limit we impose when buffering the field. */
if (len > sizeof(conn->rx.pri_fieldbuf)) {
busy = 1;
rstate->state = NGHTTP3_CTRL_STREAM_STATE_IGN_FRAME;
break;
}

/* Everything is in the input buffer. */
pri_field_value = p;
pri_field_valuelen = len;
} else if (len + conn->rx.pri_fieldbuflen >
sizeof(conn->rx.pri_fieldbuf)) {
busy = 1;
rstate->state = NGHTTP3_CTRL_STREAM_STATE_IGN_FRAME;
break;
} else {
assert(len + conn->rx.pri_fieldbuflen <= sizeof(conn->rx.pri_fieldbuf));

memcpy(conn->rx.pri_fieldbuf + conn->rx.pri_fieldbuflen, p, len);
conn->rx.pri_fieldbuflen += len;

Expand Down Expand Up @@ -1975,6 +1973,12 @@ int nghttp3_conn_on_settings_entry_received(nghttp3_conn *conn,
break;
}

#if SIZE_MAX < UINT64_MAX
if (ent->value > SIZE_MAX) {
return NGHTTP3_ERR_H3_SETTINGS_ERROR;
}
#endif /* SIZE_MAX < UINT64_MAX */

dest->qpack_max_dtable_capacity = (size_t)ent->value;

nghttp3_qpack_encoder_set_max_dtable_capacity(&conn->qenc,
Expand All @@ -1989,6 +1993,12 @@ int nghttp3_conn_on_settings_entry_received(nghttp3_conn *conn,
break;
}

#if SIZE_MAX < UINT64_MAX
if (ent->value > SIZE_MAX) {
return NGHTTP3_ERR_H3_SETTINGS_ERROR;
}
#endif /* SIZE_MAX < UINT64_MAX */

dest->qpack_blocked_streams = (size_t)ent->value;

nghttp3_qpack_encoder_set_max_blocked_streams(
Expand Down Expand Up @@ -2957,6 +2967,8 @@ int nghttp3_conn_set_client_stream_priority(nghttp3_conn *conn,
memcpy(buf, data, datalen);
}

assert(conn->tx.ctrl);

rv = nghttp3_stream_frq_emplace(conn->tx.ctrl, &fr);
if (rv != 0) {
nghttp3_mem_free(conn->mem, buf);
Expand Down
Loading