fix(spec): bump PROTOCOL_VERSION 12→13 to match spec major (unblock main CI)#2726
Merged
Conversation
chore: release packages (#2304) objectui@7a68d78f2a0c3c1f99dafd39b75b4f117a24917b
…(lockstep) The version-packages roll (#2720) took @objectstack/spec to major 13.0.0 but left PROTOCOL_VERSION at 12.0.0, so protocol-version.test.ts — the lockstep guard asserting the protocol major equals the package major — failed on main, reddening Test Core for every open PR. Restore the lockstep so the loader/installer handshake advertises the major the package actually ships. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size/s
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 93 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
main's CI is red. The version-packages roll (#2720) took@objectstack/specto major 13.0.0 but leftPROTOCOL_VERSIONat 12.0.0.packages/spec/src/kernel/protocol-version.test.ts— the lockstep guard that asserts the protocol major equals the package major — now fails:This reddens Test Core on every open PR (e.g. #2721), not just here.
Fix
Bump
PROTOCOL_VERSION12.0.0 → 13.0.0so the loader/installer handshake advertises the major the package actually ships. One-line source change + changeset.Verification
packages/specfull suite (CI-faithfulpnpm run test): 6672 passed / 247 files — the previously-failing test is green, zero regressions (matches CI's6672total).engines.protocolpins orPROTOCOL_MAJOR === 12assertions anywhere, so nothing depended on the old value.🤖 Generated with Claude Code