feat(plugin-approvals): expose per-group membership of pending approvers (objectui#2807)#3458
Merged
Merged
Conversation
…ers (objectui#2807) per_group (会签) requests now carry pending_approver_groups on the enriched row — each still-pending approver id mapped to the group key(s) it fills — so a client can label each 'waiting on' chip with its group instead of showing duplicate, context-free names. - Resolved in attachDecisionProgress from the same open-time __approverGroups snapshot decision_progress already uses, so the two never disagree - Only pending slots; synthetic (unnamed, #N) group keys dropped - Absent for non-per_group behaviors; display-only - Added to the ApprovalRequestRow contract in @objectstack/spec Closes objectui#2807 (framework half) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 24, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Framework half of objectstack-ai/objectui#2807 (a follow-up to #2762 P1-2). The approval drawer deduped repeated "waiting on" chips but couldn't say which group (finance / legal / …) each pending approver represents in a 会签 (
per_group) request — the data wasn't exposed.per_grouprequests now carrypending_approver_groupson the enriched row — a map from each still-pending approver id to the group key(s) it fills, e.g.{ "u_devadmin": ["finance", "legal"] }.attachDecisionProgressfrom the same open-time__approverGroupssnapshot thedecision_progressgroups already use, so the two never disagree.pending_approvers); synthetic (unnamed,#N) group keys are dropped — a· #0sub-tag would be noise.per_groupbehaviors. Display-only — the engine's finalization tally stays authoritative.ApprovalRequestRowcontract in@objectstack/spec.Verification
pnpm turbo build test --filter=@objectstack/plugin-approvalsgreen (8/8), incl. 2 new tests: the map tracks pending slots and drops as approvers resolve; unnamed-group and non-per_grouprequests omit it.@objectstack/spec,@objectstack/plugin-approvals).Companion: objectstack-ai/objectui#2807 UI half (labels the chips), PR filed there.
Closes objectstack-ai/objectui#2807 (framework half)
🤖 Generated with Claude Code
https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
Generated by Claude Code