fix(security): bump vulnerable deps flagged by Dependabot - #33008
fix(security): bump vulnerable deps flagged by Dependabot#33008harsh-vador wants to merge 2 commits into
Conversation
- stream-json 1.7.5 -> 3.5.0 via root resolutions (GHSA-528h-pc64-c93x, DoS). quicktype@20 pins 1.7.5; the repo only uses `quicktype -s schema` (json2ts.sh / json2ts-generate-all.sh), verified working with 3.5.0. - js-yaml 3.15.1 -> 3.15.2 in tooling/antd-codemods (GHSA-2883-xcg3-v3hh) - svgo 3.3.4 -> 3.3.5 in ui-core-components (GHSA-w27v-7q3p-w38r, GHSA-4vpr-x523-8j87) - vitest 3.2.7 -> 4.1.11 in ui-core-components (GHSA-82fw-gwwq-j7x9, @vitest/mocker path traversal). Dev-only; suite parity with main (88 passed, 1 pre-existing failure in table.test.tsx) and `yarn build` green. Added `vite: 7.3.5` resolution to collapse the duplicate vite lock entries that trip yarn 1's peer linker under vitest 4 ("could not find a copy of vite to link"). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 574 passed · ❌ 0 failed · 🟡 2 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 53m 9s ⏱️ Max setup 4m 17s · max shard execution 16m 33s · max shard-job elapsed before upload 19m 42s · reporting 6s 🌐 235.37 requests/attempt · 2.82 app boots/UI scenario · 19.84% common-shard skew Optimization targets still in progress:
🟡 2 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedBumps 6 vulnerable dependencies flagged by Dependabot: stream-json, js-yaml, svgo, vitest, and OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
…33018) * fix(security): bump stream-json 1.7.5 -> 3.5.0 (backport 2.0) GHSA-528h-pc64-c93x (DoS). quicktype@20 pins 1.7.5; the repo only uses `quicktype -s schema` (json2ts.sh / json2ts-generate-all.sh), verified working with 3.5.0. Backport of the stream-json part of #33008; the js-yaml (tooling/antd-codemods) and vitest/svgo (ui-core-components) parts don't apply — those deps don't exist on 2.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: document why the stream-json resolution override is safe Review feedback on #33018: the override jumps two majors past quicktype's exact pin, so record the verified-safe usage (schema mode only) and the re-verification duty on future quicktype upgrades. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Summary
Fixes 6 open Dependabot alerts:
resolutions)stream-json compatibility
quicktype@20.0.27pinsstream-json@1.7.5exactly; 3.5.0 is ESM-only, so the bump needs theresolutionsoverride. This repo only invokes quicktype in schema mode (json2ts.sh,json2ts-generate-all.sh, and the typescript-type-generation workflow), which works with 3.5.0 (verified codegen). quicktype's JSON-sample input mode breaks under 3.5.0, but nothing here uses it. Same change already merged in Collate (open-metadata/openmetadata-collate#6455) with byte-identical regenerated output there.vitest 4 notes (ui-core-components)
table.test.tsx("can omit the selection cell for a full-width synthetic row") that fails identically on pristine main — pre-existing, unrelated.yarn buildgreen.vite: 7.3.5resolution: vitest 4 moves vite to a peer dependency, and the duplicate vite lock entries (7.3.5/7.3.6) trip yarn 1's peer linker ("could not find a copy of vite to link"). Pinning collapses them to the single version the package already uses.Not addressed (no patched release exists / not a dep bump)
🤖 Generated with Claude Code