Repository navigation
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 medium |
🟢 Metrics 8 complexity
Metric Results Complexity 8
🟢 Coverage ∅ diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation (-1.00%) Diff coverage ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (9c7ecc1) 93830 27062 28.84% Head commit (18fc08c) 93867 (+37) 27079 (+17) 28.85% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3839) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
f1e3f7d to
c47e107
Compare
butonic
changed the title
Co-authored-by: Firas Frikha <firas.frikha@kiteworks.com>
Pins reva to the workpackages branch (2d4db7d27), which carries the upload coordinator and the other WP1 storage changes on top of reva main. Once workpackages lands in reva main this becomes a regular bump to main. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Firas Frikha <firas.frikha@kiteworks.com>
Upload sessions whose node metadata can no longer be read can never
finish postprocessing, stay in processing state indefinitely and keep
consuming the quota of their space.
Wire up the Orphaned session filter so operators can list the affected
sessions and remove them with --clean:
opencloud storage-users uploads sessions --orphaned
opencloud storage-users uploads sessions --orphaned --clean
Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
The driver no longer consumes postprocessing events: the upload coordinator does, in the "dcfs" group, and the driver only consumes DeleteRevision in "dcfs-revisions". The command still disables async uploads so it does not join that group. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
…on PostprocessingFinished The storage drops postprocessing events that belong to another storage, which needs its mount id and the resource id on the event.
Postprocessing results are dropped when their storage id does not match the driver's mount id. Only the decomposed driver was given a mount_id, so under decomposeds3 there was nothing to compare against. Also pass it in DecomposedNoEvents and DecomposedS3NoEvents.
The upload coordinator reads the mount id from the driver config to drop postprocessing results that belong to another storage. The dataprovider does not add it to the driver config the way the storageprovider does, so without it the coordinator accepts every result for posix. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
The remote instance still sees the share with the role it was created with, so the upload coordinator refuses the upload there instead of the owner's instance failing it with 500. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Picks up opencloud-eu/reva#978: a failed blob commit now logs the space and node id, and the last attempt logs that we give up. This runs the rest of the `owncloud/reva#733` port through the opencloud CI. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Picks up the space manager checks from opencloud-eu/reva#990 and opencloud-eu/reva#993. go-chi and go-jose move up because reva requires the newer versions. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
6b43871 to
0da2e89
Compare
pbleser-oc
left a comment
pbleser-oc
left a comment
There was a problem hiding this comment.
Looks good to me. Since the CI only runs on posix, I ran the upload features locally on the decomposed driver, with async uploads and ClamAV: apiSpaces/uploadSpaces, apiSpaces/tusUpload, coreApiWebdavUploadTUS/uploadFile and checksums, and cliCommands/uploadSessions (including the antivirus scenarios) all pass. So the mount id matches there too, and the uploads command works through the coordinator.
One thing that might be worth a line in the description: storage-users now needs a local upload directory for every driver. eos, eoshome, eosgrpc and owncloudsql have no root in their configuration, so with this change the storageprovider and the dataprovider refuse to start with "cannot determine the upload directory, set upload_directory". These drivers aren't maintained any more, so I don't think it needs a fix, but whoever still uses one of them would run into it on the update.
Brings in opencloud-eu/reva#1001, which merges reva main into workpackages: the typed storage results, the fix for synchronous uploads stuck in processing (moved to the upload coordinator), the main-queue replica fix and the posix id cache fail fast. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
micbar
left a comment
micbar
left a comment
There was a problem hiding this comment.
We fix the codacy issue later, go jose v3 needs to be removed.
workpackages was merged into reva main with opencloud-eu/reva#957, so we no longer need to pin the workpackages branch. The code is the same as 7ff1d6fb1, only the version changes. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Switches opencloud to the reva upload coordinator: uploads are initiated, received, postprocessed and committed by
pkg/uploadinstead of the storage drivers.<storage root>/uploads, and the storage-users dataprovider gets the mount id.opencloud storage-users uploads sessionslists the sessions through the coordinator, since the drivers no longer keep them.--orphanedfilter foruploads sessions: it lists the sessions whose node metadata can no longer be read, and--cleanremoves them and gives their quota back.Assisted by Claude Code (claude-opus-5-5): it rebased the branch onto main, bumped reva to workpackages, and drafted this description.