Skip to content

ADDON_DATA: create bin/data and nested folders before copying (#619) - #679

Closed
danoli3 wants to merge 1 commit into
openframeworks:masterfrom
danoli3:addon-data-create-dirs
Closed

danoli3 wants to merge 1 commit into
openframeworks:masterfrom
danoli3:addon-data-create-dirs

Conversation

@danoli3

@danoli3 danoli3 commented Oct 25, 2026

Copy link
Copy Markdown
Member

Fixes #619.

copyAddonData used fs::create_directory (one level) on the destination and nothing for single files, so a project without bin/data yet (just src/ + addons.make) failed to get its addon data: Error creating directories ... No such file or directory / Can not add addon data file. Now create_directories on the destination folder (the folder itself for a directory, the parent for a file) before copying.

Tested an addon with ADDON_DATA = data/addon_shaders (folder), data/settings.json (file), data/deep/er/n.txt (nested file), into a project with only src/ + addons.make:

linux64 osx vs
master nothing copied, errors folder + file, nested file missing nothing copied, errors
this PR all 3 all 3 all 3

@danoli3

danoli3 commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Combined into #683.

@danoli3 danoli3 closed this Oct 25, 2026
@danoli3
danoli3 deleted the addon-data-create-dirs branch October 25, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug Linux?] when processing addon data, PG is thrown off if intermediary directories are not preexisting

1 participant