Repository navigation
0.12.2 fixes: ADDON_DATA folders, no empty addons.make, Xcode paths with spaces, remember OF path, keep missing addons - #683
Merged
Conversation
… value, quoted like Xcode does (openframeworks#303)
…s tab, never replace a valid path with a detected non-OF one (openframeworks#602)
…r the addons with Download (addons.make #url) / Find on GitHub (openframeworks#258)
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for 0.12.2. Replaces #679, #680, #681, #682.
Fixes #619, fixes #297, fixes #303, fixes #602, fixes #258.
ADDON_DATA into a project without
bin/data(#619)copyAddonDatausedfs::create_directory(one level) and nothing for single files, so a project with justsrc/+addons.makegotError creating directories/Can not add addon data file. Nowcreate_directoriesfor the destination folder (the folder itself, or a file's parent) first.Tested
ADDON_DATAfolder + file + nested file: master linux64 / vs copied nothing, osx missed the nested file; now all three on linux64 / osx / vs.No empty
addons.make(#297)Only written when the project has addons (found or missing) or already has one, so removing every addon still clears it. New project without addons on osx / linux64 / vs / vscode -> no
addons.make.Xcode header search paths with spaces (#303)
The pbxproj writer appended only the first word of array settings, so
src/sub folderbecamesrc/suband../addons/ofxSpace Addon/srcbecame../addons/ofxSpace. Now the whole value, quoted the way Xcode writes paths with spaces ("src/sub folder").#include <deep.h>fromsrc/sub folderfailed on master (file not found with <angled> include), builds with this (xcodebuildRelease arm64).GUI remembers a manually set OF path (#602)
Launch and the Settings tab replaced the OF path with
--getofpath's answer (../../..with the app outside an OF tree). A path picked in the folder dialog or typed now setsofPathManualand is kept while it's an openFrameworks folder; detection never replaces a valid path with a non-OF one; the ofPath button still re-detects (and clears the flag). Renderer strings fall back to English for keys a translation doesn't have.Missing addons stay in
addons.make(#258)addons.make(line as written,#urlcomment included) and logged as[ error ] ... addon not found: ofxFoo - kept in addons.make, install it or fix the nameinstead of being dropped silently.#https://...@commitcomment, then re-import) when there's a URL, Find on GitHub always. Missing addons are passed back on update so they're kept. Red message text updated (they're no longer removed), all 9 locales.addons.makeand-a(GUI path) both keepofxDoesNotExist #https://github.com/someone/ofxDoesNotExist@abc123; GUI import shows both missing addons, Download only for the one with a URL,ofxOscstill selected.Modular libraries: Windows installed per arch
The installed column showed one
Windowslabel for anylib/vs, green for every Windows target once one arch was installed. NowWindows (x64)/Windows (arm64)/Windows (arm64ec)fromlib/vs/<arch>(andbin/vs/<arch>for DLL-only libs like glon12), green only for the selected target; a flat oldlib/vsstill showsWindows. Tested with the glon12 modular zips: x64 ->Windows (x64), + arm64 -> both.cmdline 0.115.0, GUI 0.108.0.