Skip to content

The Jakarta interceptor migration completes InvocationContext decorators with getConstructor() - #1281

Merged
jkschneider merged 1 commit into
jakarta/jackson-provider-overridesfrom
jakarta/invocation-context-get-constructor
Oct 3, 2026
Merged

jkschneider merged 1 commit into
jakarta/jackson-provider-overridesfrom
jakarta/invocation-context-get-constructor

Conversation

@jkschneider

Copy link
Copy Markdown
Member

jakarta.interceptor.InvocationContext adds getConstructor(), so a hand-written javax decorator that delegated to a wrapped context stopped compiling after JavaxInterceptorToJakartaInterceptor. New recipe InvocationContextGetConstructor, run after the package change, adds a getConstructor() that delegates to the same receiver when a direct implementation, an anonymous class or a named class extending only Object, returns x.getMethod() from its getMethod() with x an InvocationContext. Classes that already implement getConstructor(), that do not delegate, or that extend another class are left alone.

Found by a team of coding agents reviewing a Moderne run of org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta over the 31 Arquillian repositories (run 20261003120559-YQoma). The issue is invocation-context-get-constructor-missing in the run's io.moderne.RecipeIssues data table (1 row), and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:

A migrated InvocationContext decorator does not implement the required getConstructor method. (arquillian/continuous-enterprise-development, code/application/web/rest/core/src/main/java/org/cedj/geekseek/web/rest/core/interceptor/RESTInterceptorEnabler.java, recipe org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta)

Before:

new javax.interceptor.InvocationContext() { /* existing methods delegate to context */ public Method getMethod() { return context.getMethod(); } }

What the recipe produced:

new jakarta.interceptor.InvocationContext() { /* existing methods delegate to context */ public Method getMethod() { return context.getMethod(); } }

Expected:

new jakarta.interceptor.InvocationContext() { /* existing methods delegate to context */ public Method getMethod() { return context.getMethod(); } public Constructor<?> getConstructor() { return context.getConstructor(); } }

Stacked on #1280 (18 of 19); merge that one first.

@jkschneider
jkschneider force-pushed the jakarta/invocation-context-get-constructor branch from 5fb580d to 7cf29be Compare October 3, 2026 22:26
@jkschneider
jkschneider added this pull request to stack #1283 October 3, 2026 22:39
@jkschneider
jkschneider merged commit b63048f into jakarta/reflective-type-names Oct 3, 2026
@jkschneider
jkschneider deleted the jakarta/invocation-context-get-constructor branch October 3, 2026 22:41
jkschneider added a commit that referenced this pull request Oct 4, 2026
#1271)

* javax-reflective-names-retained: migrate runtime Jakarta type names

* maven-coordinate-literal-retained: migrate validation artifact lookups (#1272)

* weld-javax-provider-retained: align Weld core with Jakarta CDI (#1273)

* `JettyUpgradeEE9` also upgrades the other Jetty dependencies, the servlet packages and the Java version (#1274)

* jetty-ee9-java-baseline: align Jetty dependencies packages and Java baseline

* jetty-ee9-java-baseline: leave standalone Jetty utility dependencies unchanged

* jetty-ee9-java-baseline: require a direct dependency before upgrading Java

* `JacksonJavaxToJakarta` keeps newer Jackson versions and shared version properties when relocating artifacts (#1275)

* jackson-version-downgrade: preserve newer versions and shared properties

* jackson-shared-version-property-split: cover older shared Jackson versions

* The Jakarta JAXB migration keeps the `javax.xml.bind` API for Arquillian Recorder 1.x binaries (#1276)

* recorder-javax-jaxb-api-removed: retain the API needed by Recorder binaries

* recorder-javax-jaxb-api-removed: limit retention to external binaries after migration

* hibernate-validator-javax-provider-retained: migrate legacy validation providers (#1277)

* legacy-javaee-api-coordinate-retained: migrate legacy annotation EL and EJB aliases (#1278)

* The Jakarta migration keeps a provided API provided instead of adding it again in compile scope (#1279)

* cdi-provided-scope-promoted: preserve provided CDI API scope

* cdi-provided-scope-promoted: distinguish provided declarations from runtime APIs

* provided-api-scope-overwritten: preserve provided Mail API scope

* provided-api-scope-overwritten: preserve container API scopes across Jakarta migrations

* The Jackson Jakarta migration adds the `defaultView` parameter to `ProviderBase._configForWriting` overrides (#1280)

* jackson-provider-override-signature: forward the default view parameter

* jackson-provider-override-signature: update callers of migrated overrides

* invocation-context-get-constructor-missing: complete legacy decorators (#1281)

* jakarta-api-duplicates-platform: respect provided platform APIs (#1282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant