Skip to content

Add live-view PTZ preset and home position controls - #665

Merged
matteius merged 1 commit into
mainfrom
agent/issue-658-ptz-presets
Oct 19, 2026
Merged

matteius merged 1 commit into
mainfrom
agent/issue-658-ptz-presets

Conversation

@matteius

Copy link
Copy Markdown
Contributor

Closes #658.

Summary

  • Add live-view controls to name and save the current PTZ position as an ONVIF preset, then refresh the preset dropdown so it can be used immediately.
  • Add a confirmed action to set the current position as home. Show each action only when the camera reports the corresponding capability, and hide both after a 403 response.
  • Add English UI strings, success and failure toasts, and accessible labels for the controls.

Validation

  • cd web && npm test -- --runInBand — 401 tests passed, including mocked fetch coverage for request methods, URLs, bodies, capability loading, 403 handling, and preset refresh.
  • cd web && npm run lint — zero errors; existing repository warnings remain. Changed PTZ files have zero warnings.
  • cd web && npx vite build — passed after generating the ignored web/js/version.js with node scripts/extract_version.js.
  • Manual ONVIF PTZ hardware test was not run; no camera was available in this environment.

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@matteius
matteius merged commit 784c8b7 into main Oct 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Agent] PTZ: UI to save presets and set home position

1 participant