Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Zuul encountered a syntax error while parsing its while parsing a block collection |
9e585b1 to
cddc303
Compare
|
Build failed (check pipeline). Post ✔️ s2i-openstack-containers-molecule SUCCESS in 2m 10s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ s2i-openstack-containers-molecule SUCCESS in 2m 04s |
|
it seems centos10 update broke it, i'm checking what the issue is. |
UBI10 has openssl-libs-3.5.8-1.el10_2.x86_64 which is newer from nvr that the centos one which is openssl-libs-1:3.5.8-1.el10.x86_64 |
| - s2i-openstack-container-content-provider | ||
| - s2i-openstack-container-consumer-smoke | ||
| - s2i-openstack-deploy-validation-watcher: | ||
| irrelevant-files: *irrelevant-for-zuul |
There was a problem hiding this comment.
so ideealy instead of addin ght job directly we would add it to a watcher porject template and we need to have this trigger on its own file list
sepeicifly it shoudl triger on change to teh base contaienr or watcher contaienr folders but not all folders so
irrelevant-files: *irrelevant-for-zuul
is not the correct approch, we want to invert it and only list the subpath that we need the job to run on
| run: playbooks/container-ci/zuul/consumer-smoke.yaml | ||
|
|
||
| - job: | ||
| name: s2i-openstack-deploy-validation-watcher |
There was a problem hiding this comment.
we also shoudl not be defineing the job in this repo
the defintion should be in the watcher-operator repo and only reused form this repo
There was a problem hiding this comment.
@amoralej do you also agree that that this job should be in the watcher-operator repo? If so, will close this and redefine there
There was a problem hiding this comment.
you would sill need this change to add the job defiention to trigger on this repo
the intent is to have a common job defieiotn in the watcher-oeprator repo htat can trigger on changes to both repos based on diffetn set of files
There was a problem hiding this comment.
I was thinking in adding it here to test to avoid having two changes with depends-on, etc... and make it easier. At the end, yep, it may be good to define the job or maybe a template in watcher-operator repo.
There was a problem hiding this comment.
ok - will define the job in watcher-operator - and then change this PR to reference it
There was a problem hiding this comment.
so we have watcher-s2i-tempest already
https://github.com/openstack-k8s-operators/watcher-operator/blob/main/.zuul.yaml#L139-L181
which currently inherits form watcher-operator-validation-base which exented watcher-operator-base and that currently inherites form podified-multinode-edpm-deployment-crc-2comp
https://github.com/openstack-k8s-operators/watcher-operator/blob/main/.zuul.yaml#L60-L87
https://github.com/openstack-k8s-operators/watcher-operator/blob/main/.zuul.yaml#L2-L20
my expecation is watcher-operator-base will be update to inherit form
s2i-test-base in the next week or two so that all out tempest jobs derive form that as its baseline, and here woudl just run watcher-s2i-tempest here with overriden files:
we do not need a duplicate job defiention becuase zuul supprot job variant so when you add watcher-s2i-tempest to github-check via a templeate or directly you can add it as
github-check:
watcher-s2i-tempest:
files:
- containers/watcher
- containers/base
dependencies:
- s2i-openstack-container-content-provider
- s2i-openstack-container-consumer-smoke
and we are done from the point of view of this repo
all of the rest lives in -operator
There was a problem hiding this comment.
by the way the only reason i was suggesting a template is to turnt that 7 line addtion to the project into a one line addtion of the template and alow you to have that templelate out of line but its its not strictly required
There was a problem hiding this comment.
We discussed in last s2i call about the patter to add coverage for deployment specific scenarios to s2i. As mentioned here, we should be creating a template in watcher-operator and just adding. @tosky proposed https://github.com/openstack-k8s-operators/s2i-openstack-containers/pull/213/changes to stablish a naming convention which seems fine.
There was a problem hiding this comment.
sure <repo>-s2i-component-jobs is fine it helps us find them later.
cddc303 to
dc3f1c6
Compare
|
Zuul encountered a syntax error while parsing its Job ^containers/watcher/s2i-openstack-container-consumer-smoke not defined The problem appears in the "openstack-k8s-operators/s2i-openstack-containers" project stanza: project: in "openstack-k8s-operators/s2i-openstack-containers/zuul.d/projects.yaml@main", line 2 |
dc3f1c6 to
0a5b21d
Compare
|
Zuul encountered a syntax error while parsing its Job ^containers/watcher/s2i-openstack-container-consumer-smoke not defined The problem appears in the "openstack-k8s-operators/s2i-openstack-containers" project stanza: project: in "openstack-k8s-operators/s2i-openstack-containers/zuul.d/projects.yaml@main", line 2 |
0a5b21d to
ed96892
Compare
|
Zuul encountered a syntax error while parsing its Job 2i-openstack-container-consumer-smoke not defined The problem appears in the "openstack-k8s-operators/s2i-openstack-containers" project stanza: project: in "openstack-k8s-operators/s2i-openstack-containers/zuul.d/projects.yaml@main", line 2 |
ed96892 to
86a00a0
Compare
|
Build failed (check pipeline). Post ✔️ s2i-openstack-containers-molecule SUCCESS in 2m 06s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ s2i-openstack-containers-molecule SUCCESS in 2m 03s |
|
Build failed (check pipeline). Post ❌ s2i-openstack-containers-molecule NODE_FAILURE Node(set) request 100-0000205893 failed in 0s |
|
recheck |
|
Zuul encountered a syntax error while parsing its while parsing a block mapping |
2bc9657 to
1ce3a64
Compare
|
Build failed (check pipeline). Post ✔️ s2i-openstack-containers-molecule SUCCESS in 2m 06s |
ea46276 to
1ea14ea
Compare
|
Build failed (check pipeline). Post ✔️ s2i-openstack-containers-molecule SUCCESS in 2m 04s |
watcher and base container changes should be gated by Watcher jobs. This PR adds a template to include Watcher testing on those directories. Depends-On: openstack-k8s-operators/watcher-operator#457
1ea14ea to
c9e95c7
Compare
|
Zuul encountered a syntax error while parsing its The project template "watcher-operator-s2i-component-jobs" was not The problem appears in the "openstack-k8s-operators/s2i-openstack-containers" project stanza: project: in "openstack-k8s-operators/s2i-openstack-containers/zuul.d/projects.yaml@main", line 2 |
|
This will fail until the Depends-On changes has merged - expected with a template addition |
It looks like Depends-On works, but you need to set it in the PR description. (I guess we need to coordinate the merges) |
|
recheck |
|
Thank you @tosky . checking run with Depends-On. |
SeanMooney
left a comment
SeanMooney
left a comment
There was a problem hiding this comment.
this looks correct but we need to be carful of the merge order.
|
Build failed (check pipeline). Post ❌ watcher-s2i-tempest FAILURE in 1h 51m 01s |
|
check-rdo |
|
Build failed (check pipeline). Post
|
|
check-rdo |
|
Build failed (check pipeline). Post
|
|
recheck |
|
Build failed (check pipeline). Post ✔️ watcher-s2i-tempest SUCCESS in 1h 56m 04s |
|
check-rdo |
|
Build succeeded (check pipeline). ✔️ watcher-s2i-tempest SUCCESS in 1h 59m 21s |
5 participants
This PR adds a full deployment job with Watcher.