Skip to content

🌱 Disable optionalfields and requiredfields linter rules #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtfranz wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

🌱 Disable optionalfields and requiredfields linter rules #3073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1/clusterobjectset_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ type ClusterObjectSetSpec struct {
// +listType=map
// +listMapKey=name
// +optional
Phases []ClusterObjectSetPhase `json:"phases,omitempty"`
Phases []ClusterObjectSetPhase `json:"phases,omitempty"` //nolint:kubeapilinter

// progressDeadlineMinutes is an optional field that defines the maximum period
// of time in minutes after which an installation should be considered failed and
Expand Down Expand Up @@ -555,7 +555,7 @@ type ClusterObjectSetStatus struct {
// +listType=map
// +listMapKey=name
// +optional
ObservedPhases []ObservedPhase `json:"observedPhases,omitempty"`
ObservedPhases []ObservedPhase `json:"observedPhases,omitempty"` //nolint:kubeapilinter

// completedAt is the timestamp at which the revision was first observed to be
// ready, meaning it had successfully rolled out and all of its objects passed
Expand Down
6 changes: 2 additions & 4 deletions hack/api-lint-diff/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,8 @@ linters:
linters:
disable:
- nonpointerstructs
lintersConfig:
optionalfields:
pointers:
preference: WhenRequired
- optionalfields # We use omitzero on optional fields and this causes the linter to complain about them not having omitempty
- requiredfields # We do not always use omitempty/omitzero on required fields, which this linter enforces
run:
timeout: 5m

Expand Down
Loading