[juliusmarminge]

The link-card test "a later provider session reusing a clientRequestId gets a card of its own" described the wrong boundary. A card's retry key includes the MCP credential's request namespace, so what gets a new card is a new MCP credential (after a restart, an idle release or an access change). A replacement provider session that reuses a still-valid credential finds the first card. GoatXYZ pointed this out on https://git.cafe/pingdotgg/t3code/pulls/17129.

The test is now named "a new MCP credential reusing a clientRequestId gets a card of its own", and the PeerLinkRequests.request docstring says a retry needs the same clientRequestId and MCP credential. No behavior changes.

Verification: PeerLinkRequests.test.ts passes (18 tests); lint and format are clean.

Claude Opus 5.5 through Claude Code in T3 Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at c3f6de5

Macroscope's review found this PR approvable — The documentation now clarifies that link-card retries require the same request ID and MCP credential. The assessed change does not alter runtime behavior or product defaults.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.3 KiB	1.3 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	21.6 KiB	21.6 KiB	0 B (0.0%)	24.4 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.1 KiB	5.0 KiB	−35 B (−0.7%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.3 KiB	1.2 KiB	−35 B (−2.7%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.9 KiB	21.9 KiB	−41 B (−0.2%)	24.4 KiB	✅
Claude	Live turn messages	2	1	−1 (−50.0%)	8	✅

Baseline: 5e9d564 · PR result: c3f6de5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: t3code/peer/link-card-credential-test-name
• File: .coderabbit.config.ts
• Commit: c3f6de5
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 33fc66b6-cd55-4d48-8632-462a109d1d61

Commits

Reviewing files that changed from the base of the PR and between 5e9d564 and c3f6de5.

Files selected for processing: 2

• apps/server/src/peer/PeerLinkRequests.test.ts
• apps/server/src/peer/PeerLinkRequests.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The request documentation now specifies that returning the current card outcome on retry requires the same clientRequestId and MCP credential. The test title now describes reuse under a new MCP credential. Test logic is unchanged.

Changes: Link request retry contract

Layer / File(s)	Summary
Document and name the retry condition apps/server/src/peer/PeerLinkRequests.ts, apps/server/src/peer/PeerLinkRequests.test.ts	The request documentation specifies that retries return the current card outcome when both the clientRequestId and MCP credential match. The test title describes reuse under a new MCP credential; test logic is unchanged.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related PRs

• pingdotgg/t3code#24850: Updates the shared clientRequestId retry contract, which this change applies to link cards with an MCP credential condition.

Suggested labels: size:XS

Merge Risk: Minimal · up to c3f6d

No actionable merge-blocking risk was identified.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem (the test named the wrong boundary for card reuse), the change (test renamed and the PeerLinkRequests.request docstring updated, no behavior change), and the verif…	Add the template headings: Problem, Change, Scope and approval, and Verification. Under Scope and approval, link the triaged issue or the discussion with explicit maintainer approval, including the approval comment. Or explain why this very…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title names the actual change: the link-card retry test now refers to a new MCP credential instead of a later provider session. It is specific and matches the test rename and docstring update. The…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the actual change: the link-card retry test now refers to a new MCP credential instead of a later provider session. It is specific and matches the test rename and docstring update. The title uses a conventional commit form and is a single sentence of 10 words.

Full details: Description check

Explanation

The description explains the problem (the test named the wrong boundary for card reuse), the change (test renamed and the PeerLinkRequests.request docstring updated, no behavior change), and the verification (PeerLinkRequests.test.ts passes with 18 tests; lint and format clean). It omits the 'Scope and approval' section, which the template requires to link a triaged issue or maintainer-approved discussion, or to justify an exemption for a very small, obvious fix. It also does not use the template's section headings (Problem, Change, Scope and approval, Verification). The author does reference an external pull request thread where a reviewer raised the point, which is not the same as a maintainer approval of direction and scope.

Resolution

Add the template headings: Problem, Change, Scope and approval, and Verification. Under Scope and approval, link the triaged issue or the discussion with explicit maintainer approval, including the approval comment. Or explain why this very small, focused test and docstring fix qualifies without a prior issue or discussion. Keep the existing verification details. Remove the trailing agent attribution or move it to the end as the template asks.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}