Repository navigation
fix(mobile): the Android split slides as one rigid strip with the keyboard #26328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
4
commits into
t3/fix-android-wide-navigation-transitions
from
t3/android-split-rigid
+92
−16
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9826562
fix(mobile): the Android split slides as one rigid strip with the key…
juliusmarminge a6ea489
fix(mobile): the Android navigation rail slides with the keyboard strip
juliusmarminge ad7f1d6
fix(mobile): the Android navigation rail stays while the keyboard col…
juliusmarminge 11d55f7
fix(mobile): the detail card fills the strip it leaves while the keyb…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: pingdotgg/t3code
Length of output: 42512
Script executed:
Repository: pingdotgg/t3code
Length of output: 42129
Script executed:
Repository: pingdotgg/t3code
Length of output: 11860
Web query:
react-native-keyboard-controller 1.22.8 useKeyboardContext reanimated progress keyboardWillHideResult:
Script executed:
Repository: pingdotgg/t3code
Length of output: 5464
Keep the overhang visible while the keyboard hides.
keyboardWillHideclears the keyboard-dependent layout state before the keyboard transition completes. WhencomposerKeyboardActivebecomesfalse, the content returns to its narrower settled width whilekeyboardProgresscan still be1. The strict upper-bound check hides the overhang at that endpoint and exposes the row’sbg-headerbackground instead of the thread canvas. Include the endpoint in the overhang condition.🐛 Suggested fix
Committable suggestion