Skip to content

ci: post merge notices on pull_request, not pull_request_target #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gorandodig wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: post merge notices on pull_request, not pull_request_target #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/notify-slack-on-main-merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Notify Slack on Merge to Main

# Posts to Slack when a PR lands on main. Opening a PR notifies nobody.
# pull_request_target runs this file from main with secrets, so merged PRs from
# forks post too. Nothing from the PR is checked out or run; the title only
# reaches the shell through an env var.
# pull_request, not pull_request_target: GitHub blocks the latter in public
# repos by default from December 2026. Fork PRs get no secrets here, so their
# merges post nothing. The title only reaches the shell through an env var.
on:
pull_request_target:
pull_request:
types: [closed]
branches: [main]

Expand All @@ -15,7 +15,10 @@ jobs:
notify:
name: Notify Slack
runs-on: ubuntu-latest
if: ${{ github.event.pull_request.merged && vars.SLACK_CHANNEL_ID != '' }}
if: >-
github.event.pull_request.merged &&
github.event.pull_request.head.repo.full_name == github.repository &&
vars.SLACK_CHANNEL_ID != ''

steps:
# Slack reads <, > and & as markup: escape them so a PR title cannot
Expand Down
Loading