Skip to content

Sync upstream whatsmeow through 4b4986f - #53

Open
purpshell wants to merge 19 commits into
mainfrom
codex/upstream-sync-20261027
Open

purpshell wants to merge 19 commits into
mainfrom
codex/upstream-sync-20261027

Conversation

@purpshell

@purpshell purpshell commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Summary

Sync upstream WhatsMeow while retaining HyperMeow's module paths, Signal fork, bounded caches and lifecycle controls. Terminal CAT refresh failures stop automatic reconnect and notify generic and connection-scoped observers.

The continuation fixes the reported group-permission cache race. Group metadata and both participant/admin slices are copied under the cache lock before callers read them. Two regression tests cover snapshot isolation and concurrent notification updates.

Fork-owned notices now include Polymorfa (Softium LLC). Existing personal and upstream attribution, years, license grants and the MPL/MIT boundary are preserved. The existing MEX generator produced its updated notice.

Stack

Library: this PR → newsletter observations #54.
Consumers: runner #871 → newsletter backend and docs #874, with SDK #366 and CLI #92.

Qualify the complete family before merging, then merge bottom-up. Business #55 remains under its existing owner and is not part of this writer's changes.

Verification

  • Ran the genuine MEX producer with the existing toolchain.
  • Verified attribution-only changes outside the cache fix, regression tests, generator template and changelog. The upstream MPL license is unchanged.
  • Verified committed source matches the prepared source and preserved the original worktree/index changes and old head.
  • Additional local validation is waived by the human's November 5 workflow. New regression tests have not run locally. Previous test passes remain historical; hosted checks must qualify the new head.
  • Hosted CI, exhaustive Codex code/security review and CodeRabbit disposition are required before merge. No remaining finding or skipped/cancelled/pending/failed CI task is accepted.

No API schema, SDK/CLI surface, Admin control, QuickLink/tunnel, ZK custody, feature default or history profile changes are introduced by this continuation. No live WhatsApp, package publication, deployment or activation is claimed.

Provenance and rollback

One continuing source owner: Codex in T3 Code, OpenAI, gpt-6.1-sol, xhigh, standard service. No new writer or delegate. Registration and original checkpoint. Capture is partial/manual. No UI changed.

Rollback coordinates the library integration and consumer pin, preserving device data. Merge authorization does not authorize tags, packages, deployment or feature activation.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available. Your 2 included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: b87df7c1-4aae-4a8f-9e2b-cc815ff03c00
Commits

Reviewing files that changed from the base of the PR and between 7852ff1 and e3aab2d.

Files ignored due to path filters: 10

  • benchmark/barback/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • proto/waAICommon/WAWebProtobufsAICommon.pb.go is excluded by !**/*.pb.go
  • proto/waArmadilloXMA/WAArmadilloXMA.pb.go is excluded by !**/*.pb.go
  • proto/waDeviceCapabilities/WAWebProtobufsDeviceCapabilities.pb.go is excluded by !**/*.pb.go
  • proto/waE2E/WAWebProtobufsE2E.pb.go is excluded by !**/*.pb.go
  • proto/waSyncAction/WAWebProtobufSyncAction.pb.go is excluded by !**/*.pb.go
  • proto/waWa6/WAWebProtobufsWa6.pb.go is excluded by !**/*.pb.go
  • proto/waWeb/WAWebProtobufsWeb.pb.go is excluded by !**/*.pb.go
  • proto/waWebLabyrinthWaWasm/WAWebLabyrinthWaWasm.pb.go is excluded by !**/*.pb.go
Files selected for processing: 118

  • .dockerignore
  • .github/FUNDING.yml
  • CHANGELOG.md
  • LICENSE-MIT
  • LICENSING.md
  • README.md
  • appstate.go
  • appstate/encode.go
  • appstate/encode_label_test.go
  • appstate/encode_quick_reply_test.go
  • appstate/keys.go
  • appstate_history_test.go
  • armadillomessage.go
  • benchmark/barback/.env.example
  • benchmark/barback/Dockerfile
  • benchmark/barback/Dockerfile.clientmem
  • benchmark/barback/README.md
  • benchmark/barback/cmd/bench/business_app_smoke.go
  • benchmark/barback/cmd/bench/business_app_smoke_legacy.go
  • benchmark/barback/cmd/bench/business_app_smoke_legacy_test.go
  • benchmark/barback/cmd/bench/main.go
  • benchmark/barback/cmd/bench/main_test.go
  • benchmark/barback/cmd/bench/phone_consent_sync.go
  • benchmark/barback/cmd/bench/phone_consent_sync_legacy.go
  • benchmark/barback/cmd/bench/resource_metrics.go
  • benchmark/barback/cmd/bench/security_code_smoke.go
  • benchmark/barback/cmd/bench/security_code_smoke_legacy.go
  • benchmark/barback/cmd/bench/security_code_smoke_legacy_test.go
  • benchmark/barback/cmd/bench/workload_messages.go
  • benchmark/barback/cmd/clientmem/main.go
  • benchmark/barback/comparison-matrix-env.sh
  • benchmark/barback/comparison_matrix_test.go
  • benchmark/barback/compose.dm.yaml
  • benchmark/barback/compose.local-cache.yaml
  • benchmark/barback/compose.yaml
  • benchmark/barback/go.mod
  • benchmark/barback/prepare-library-module.sh
  • benchmark/barback/results/.gitignore
  • benchmark/barback/run-client-memory.sh
  • benchmark/barback/run-comparison-matrix.sh
  • benchmark/barback/run-dm-matrix.sh
  • benchmark/barback/run-system-matrix.sh
  • benchmark/barback/testdata/results/README.md
  • benchmark/barback/testdata/results/dm-matrix.md
  • benchmark/barback/testdata/results/maxrate-ping-pong.md
  • benchmark/barback/testdata/results/memory-g128.md
  • benchmark/barback/testdata/results/ram-hardening.md
  • benchmark/barback/testdata/results/system-comparison.md
  • binary/decoder.go
  • binary/decoder_test.go
  • binary/encoder.go
  • binary/xml_test.go
  • business_test.go
  • cache.go
  • client.go
  • client_runtime_test.go
  • connection_lifecycle.go
  • connection_lifecycle_test.go
  • connection_native_retirement_test.go
  • connectionevents.go
  • connectionevents_cat_test.go
  • download-to-file.go
  • download.go
  • errors.go
  • go.mod
  • group.go
  • group_cache_snapshot_test.go
  • http.go
  • identity_test.go
  • internal/cmd/genmex/main.go
  • internals.go
  • mediaretry.go
  • messaging_test.go
  • mex/bindings.go
  • mex/bindings_test.go
  • mex/generate.go
  • msgsecret.go
  • newsletter_delete.go
  • newsletter_live_update_test.go
  • notification.go
  • pair.go
  • phone_number_message.go
  • presence.go
  • proto/waAICommon/WAWebProtobufsAICommon.proto
  • proto/waArmadilloXMA/WAArmadilloXMA.proto
  • proto/waDeviceCapabilities/WAWebProtobufsDeviceCapabilities.proto
  • proto/waE2E/WAWebProtobufsE2E.proto
  • proto/waSyncAction/WAWebProtobufSyncAction.proto
  • proto/waWa6/WAWebProtobufsWa6.proto
  • proto/waWeb/WAWebProtobufsWeb.proto
  • proto/waWebLabyrinthWaWasm/WAWebLabyrinthWaWasm.proto
  • remote_prekey_upload_test.go
  • remote_signal.go
  • remote_signal_test.go
  • reportingtoken.go
  • retry.go
  • security_code.go
  • send.go
  • sendfb.go
  • store/clientpayload.go
  • store/clientpayload_test.go
  • store/contact_test.go
  • store/sessioncache_test.go
  • store/sqlstore/identity_reader_test.go
  • store/sqlstore/lidmap_test.go
  • store/sqlstore/store_test.go
  • store/sqlstore/upgrades/upgrades_test.go
  • store/store_test.go
  • types/business.go
  • types/business_account.go
  • types/business_catalog.go
  • types/events/events.go
  • types/newsletter.go
  • types/richresponse/json_test.go
  • upstream_20261027_test.go
  • upstream_sync_test.go
  • user.go
  • util/cbcutil/cbc_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T02:33:02.527853Z e3aab2d Manual request
🔒 Security Review ✅ Completed 2026-11-05T02:35:43.735115Z e3aab2d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c0cd0e3c1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread send.go Resolved

Copy link
Copy Markdown
Member Author

@codex review

The human's November 5 workflow requires exhaustive review of the current complete PR before merge. Please review the full current diff against main, including existing upstream/fork adaptations and the group-cache race correction, generated MEX notice, license preservation and regression tests. Report all remaining actionable correctness findings. Prior review and green checks do not qualify this successor. Extra local validation was waived; hosted CI is required.

Copy link
Copy Markdown
Member Author

@codex security review

The human requires current-head security review with no remaining findings before merge. Review the complete PR against main, including protocol/crypto/session boundaries, CAT failure handling, upstream dependency/protobuf changes and cache concurrency. This request does not authorize package publication, deployment or provider effects.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: e3aab2d2f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: e3aab2d2f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: e3aab2d2f1

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: e3aab2d2f1

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants