Drop the smctl flag the pinned build does not support - #547
Merged
Conversation
The pinned smtools MSI ships an smctl without --exit-non-zero-on-fail, so every `smctl sign` invocation failed immediately with `unknown flag: --exit-non-zero-on-fail`. That build also exits 0 when signing fails, so the signtool verify and Get-AuthenticodeSignature checks are what gate the step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned smtools MSI ships an smctl without --exit-non-zero-on-fail, so every
smctl signinvocation failed immediately withunknown flag: --exit-non-zero-on-fail.That build also exits 0 when signing fails, so the signtool verify and Get-AuthenticodeSignature checks are what gate the step.