Skip to content

Drop the smctl flag the pinned build does not support #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgestagg merged 1 commit into from
Sep 11, 2026
Merged

Drop the smctl flag the pinned build does not support #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/actions/sign-files/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ runs:
}
foreach ($path in $paths) {
Write-Output "::group::Signing ${path}"
smctl sign --keypair-alias $env:SM_KEYPAIR_ALIAS --input $path --digalg SHA256 --sigalg SHA256 --timestamp=true --verbose --exit-non-zero-on-fail
# The pinned smctl build exits 0 even when signing fails and lacks
# --exit-non-zero-on-fail; the verify steps below are the failure gate.
smctl sign --keypair-alias $env:SM_KEYPAIR_ALIAS --input $path --digalg SHA256 --sigalg SHA256 --timestamp=true --verbose
if ($LASTEXITCODE -ne 0) {
Write-Output "::error title=Signing error::Error while signing ${path}"
exit 1
Expand Down
Loading