Skip to content

Preserve original OpenRTB seat in bid metadata - #4671

Open
zxPhoenix wants to merge 3 commits into
masterfrom
preserve-original-open-rtb-seat-in-bid-metadata
Open

zxPhoenix wants to merge 3 commits into
masterfrom
preserve-original-open-rtb-seat-in-bid-metadata

Conversation

@zxPhoenix

Copy link
Copy Markdown
Contributor

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Implement #2424 feature: : restore the original seat value in $.seatbid[].bid[].ext.prebid.metadata.seat when the adapter hasn’t explicitly set it.

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

Changes are covered by unit tests.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@zxPhoenix
zxPhoenix requested a review from CTMBNara October 16, 2026 09:41
@aleksUIX

Copy link
Copy Markdown

A seat with a missing or null bid list now makes Aax throw, dropping valid sibling bids. I reproduced this through real JSON decoding and makeBids in Aax, Adelement and Aja. #4675 restores the lost guards in 50 adapters, with six regressions that fail on this head and pass with the fix. The root Maven suite passes: 8,893 passed, two skipped. Can you take that patch into this branch?

…l seats (#4675)

Co-authored-by: Aleksander Sekowski <aleksander@uixlimited.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants