Repository navigation
Bidder adapters: retain null bid-list guards while preserving original seats - #4675
Merged
zxPhoenix merged 1 commit intoOct 19, 2026
Conversation
3 of 21 tasks
zxPhoenix
approved these changes
Oct 19, 2026
zxPhoenix
merged commit Oct 19, 2026
e652985
into
prebid:preserve-original-open-rtb-seat-in-bid-metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4671, targeting its feature branch.
The original-seat refactor removes existing null bid-list checks in 50 adapters. If one seat omits
bidor suppliesbid: null, the adapter throws instead of returning valid sibling bids. This restores those guards and retains the originating seat on surviving bids.Six regression tests use real JSON decoding and the public
makeBidsmethods in Aax, Adelement and Aja. They check mixed malformed/valid seats, empty responses, and preservation of the valid bid and itsoriginalSeat.Validation:
NullPointerExceptionon the original Preserve original OpenRTB seat in bid metadata #4671 head,65e16545a.