Skip to content

fix(dm): node keys get published; lowercase node ids work (v0.3.76) - #381

Merged
ralyodio merged 1 commit into
masterfrom
fix/node-dm-publish
Nov 15, 2026
Merged

ralyodio merged 1 commit into
masterfrom
fix/node-dm-publish

Conversation

@ralyodio

Copy link
Copy Markdown
Collaborator

Follow-up to #374 and #379, found sending the first real node DM (to sergey-234's mgsu3m6q):

  1. c0mpute dm send mgsu3m6q → "unknown contact". node_target only took 8-character ids that contain an uppercase letter, but ids like mgsu3m6q are all lowercase. Any 8 alphanumerics now name a node; contact names are still resolved first, and addresses (64 hex) and fingerprints (16 hex) are never 8 characters.
  2. With the full peer id → "its key is not on the network yet". The worker publishes the node key once at startup, before it has found any mailbox node, so publish_key stores it nowhere (returns 0), and the next try was 6 h later. It now retries every 30 s (doubling to 10 min) until at least one mailbox stores it, logs node key published, then refreshes every 6 h.

🤖 Generated with Claude Code

Live on 0.3.75 every node advertised its DM address, but sending to one
failed twice:
- `c0mpute dm send mgsu3m6q`: "unknown contact". node_target only took
  8-character ids with an uppercase letter; ids like mgsu3m6q are all
  lowercase. Any 8 alphanumerics now name a node (contacts are tried first).
- With the full peer id: "its key is not on the network yet". The worker
  publishes the node key once at startup, before it has found any mailbox
  node, so it is stored nowhere; the retry was 6 h away. It now retries every
  30 s (doubling to 10 min) until a mailbox stores it, then refreshes every 6 h.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

ThreatCrush Security Scan

14 finding(s)

HIGH/CRITICAL: 2 | MEDIUM: 8 | LOW: 4

Severity Rule Location
HIGH js-ssrf-outbound-request apps/web/public/sw.js:24
HIGH sh-remote-script-execution scripts/install.sh:611
MEDIUM js-unescaped-html-sink apps/web/src/app/blog/[slug]/page.tsx:53
MEDIUM js-unescaped-html-sink apps/web/src/app/layout.tsx:109
MEDIUM sql-template-interpolation apps/web/src/lib/chat/convo-store.ts:116
MEDIUM sql-template-interpolation apps/web/src/lib/chat/convo-store.ts:117
MEDIUM sql-template-interpolation apps/web/src/lib/chat/push.ts:476
MEDIUM js-dynamic-code-execution apps/web/src/lib/router/verify.ts:91
MEDIUM sh-remote-script-execution scripts/dev-setup.sh:25
MEDIUM sh-eval-expansion scripts/dev-setup.sh:35
LOW py-ssrf-outbound-request examples/business-strategist-agent/chat.py:37
LOW py-ssrf-outbound-request examples/business-strategist-agent/train.py:54
LOW secret-generic-credential node/crates/c0mpute-core/src/webhook.rs:1171
LOW py-path-traversal node/crates/c0mpute-core/tests/fixtures/fake-infernet-text:29

Snippets are redacted; ThreatCrush never prints matched credential material.

@ralyodio
ralyodio merged commit b1ed5bc into master Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant