Repository navigation
fix(dm): node keys get published; lowercase node ids work (v0.3.76) - #381
Merged
Merged
Conversation
Live on 0.3.75 every node advertised its DM address, but sending to one failed twice: - `c0mpute dm send mgsu3m6q`: "unknown contact". node_target only took 8-character ids with an uppercase letter; ids like mgsu3m6q are all lowercase. Any 8 alphanumerics now name a node (contacts are tried first). - With the full peer id: "its key is not on the network yet". The worker publishes the node key once at startup, before it has found any mailbox node, so it is stored nowhere; the retry was 6 h away. It now retries every 30 s (doubling to 10 min) until a mailbox stores it, then refreshes every 6 h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan14 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 8 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #374 and #379, found sending the first real node DM (to sergey-234's
mgsu3m6q):c0mpute dm send mgsu3m6q→ "unknown contact".node_targetonly took 8-character ids that contain an uppercase letter, but ids likemgsu3m6qare all lowercase. Any 8 alphanumerics now name a node; contact names are still resolved first, and addresses (64 hex) and fingerprints (16 hex) are never 8 characters.publish_keystores it nowhere (returns 0), and the next try was 6 h later. It now retries every 30 s (doubling to 10 min) until at least one mailbox stores it, logsnode key published, then refreshes every 6 h.🤖 Generated with Claude Code