gh-152692: Fix annotationlib.type_repr() for bound built-in methods#152693
Open
tonghuaroot wants to merge 1 commit into
Open
gh-152692: Fix annotationlib.type_repr() for bound built-in methods#152693tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…hods type_repr() returned a string naming a nonexistent module None -- e.g. type_repr([].append) == 'None.list.append' -- for bound built-in methods, whose __module__ is None. Return the qualified name when __module__ is None, as already done for the "builtins" module.
sobolevn
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type_repr()returned a string naming a nonexistent moduleNone-- e.g.type_repr([].append) == 'None.list.append'-- for bound built-in methods,whose
__module__isNone.Return the qualified name when
__module__isNone, as already done for the"builtins"module. This also covers C-accelerator functions such asrandom.random.annotations_to_stringandget_annotations(format=Format.STRING)are fixed transitively when anannotation value is such a method.