Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/annotationlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,8 @@ def type_repr(value):

"""
if isinstance(value, (type, types.FunctionType, types.BuiltinFunctionType)):
if value.__module__ == "builtins":
# Built-in methods have __module__ set to None.
if value.__module__ is None or value.__module__ == "builtins":
return value.__qualname__
return f"{value.__module__}.{value.__qualname__}"
elif isinstance(value, _Template):
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_annotationlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1850,6 +1850,10 @@ def nested():
type_repr(nested), f"{__name__}.TestTypeRepr.test_type_repr.<locals>.nested"
)
self.assertEqual(type_repr(len), "len")
# gh-152692: built-in methods have __module__ set to None
self.assertEqual(type_repr([].append), "list.append")
self.assertEqual(type_repr((1).bit_length), "int.bit_length")
self.assertEqual(type_repr(dict.fromkeys), "dict.fromkeys")
self.assertEqual(type_repr(type_repr), "annotationlib.type_repr")
self.assertEqual(type_repr(times_three), f"{__name__}.times_three")
self.assertEqual(type_repr(...), "...")
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix :func:`annotationlib.type_repr` returning a string such as
``None.list.append`` for bound built-in methods, whose ``__module__`` is
``None``. It now returns the qualified name, as it already did for other
builtins.
Loading