Skip to content

images for dark+light mode - #1641

Closed
cscheid wants to merge 5 commits into
mainfrom
images-multimode
Closed

images for dark+light mode#1641
cscheid wants to merge 5 commits into
mainfrom
images-multimode

Conversation

@cscheid

@cscheid cscheid commented Apr 28, 2025

Copy link
Copy Markdown
Member

This is going to be a bit of a slog, but we need to do it...

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://deploy-preview-1641.quarto.org

@github-actions
github-actions Bot temporarily deployed to pull request April 28, 2025 20:58 Inactive
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://deploy-preview-1641.quarto.org

@github-actions
github-actions Bot temporarily deployed to pull request April 28, 2025 21:38 Inactive
@cderv

cderv commented Jul 24, 2026

Copy link
Copy Markdown
Member

I rebuilt this as #2120 — same dark-mode elephant images, but Quarto 1.9 shipped native list-tables since this PR was opened, so the vendored pandoc-ext/list-table filter here isn't needed anymore.

@cderv cderv closed this Jul 24, 2026
cderv added a commit that referenced this pull request Jul 24, 2026
Figures and Markdown Basics currently ship light-only elephant
screenshots, which look jarring against a dark background for readers
using the site's dark theme. Revives #1641, dropping its vendored
pandoc-ext/list-table Lua filter in favor of the native list-table
syntax Quarto 1.9 shipped after that PR went stale.

Also wires up layout-attrib-negative-dark.png, which the original PR
added but never referenced.
cderv added a commit that referenced this pull request Jul 24, 2026
Figures and Markdown Basics currently ship light-only elephant
screenshots, which look jarring against a dark background for readers
using the site's dark theme. Revives #1641, dropping its vendored
pandoc-ext/list-table Lua filter in favor of the native list-table
syntax Quarto 1.9 shipped after that PR went stale.

Also wires up layout-attrib-negative-dark.png, which the original PR
added but never referenced.
cderv added a commit that referenced this pull request Jul 24, 2026
…sics docs (#2130)

Figures and Markdown Basics currently ship light-only elephant
screenshots, which look jarring against a dark background for readers
using the site's dark theme. Revives #1641, dropping its vendored
pandoc-ext/list-table Lua filter in favor of the native list-table
syntax Quarto 1.9 shipped after that PR went stale.

Also wires up layout-attrib-negative-dark.png, which the original PR
added but never referenced.

(cherry picked from commit c736ea0)

Co-authored-by: Christophe Dervieux <christophe.dervieux@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants