Add dark-mode images for figures and markdown-basics docs - #2120
Merged
Conversation
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2120.quarto.org 🔄 Modified Documents |
Member
Author
|
Preview checked on deploy build (https://deploy-preview-2120.quarto.org) — figures, markdown-basics, tables, cross-references pages. Verified light/dark image swap via computed style, and confirmed no broken image links (all 200s). Closed #1641 as superseded. |
Figures and Markdown Basics currently ship light-only elephant screenshots, which look jarring against a dark background for readers using the site's dark theme. Revives #1641, dropping its vendored pandoc-ext/list-table Lua filter in favor of the native list-table syntax Quarto 1.9 shipped after that PR went stale. Also wires up layout-attrib-negative-dark.png, which the original PR added but never referenced.
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2120.quarto.org 🔄 Modified Documents |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figures and Markdown Basics ship light-only elephant screenshots, which look jarring against a dark background when readers toggle the site's dark theme.
Documents can now show a dark-mode variant for each image, using the existing
.light-content/.dark-contentconvention already used elsewhere on the site.Supersedes #1641, which added these dark assets back in April 2025 but went stale. That PR vendored a
pandoc-ext/list-tableLua filter to mix code blocks and images in table cells; this rewrites that markup using the list-table syntax Quarto 1.9 shipped natively, so no extension is needed.Also wires up
layout-attrib-negative-dark.png, an asset #1641 added but never referenced.