feat(build,linux): Add Makefile script for build targets - #732
Merged
Merged
Conversation
rabbitstack
changed the title
The Makefile script automates the process of compiling the eBPF programs, Fibratus binary, running tests, formatting, etc. The bpf2go now drops all generated Go files + ebpf bytecode inside a separate bpf package making it easier to navigate and distinguish the generated code.
rabbitstack
force-pushed
the
add-makefile-for-build-targets
branch
from
September 16, 2026 16:20
4cc4d96 to
cf31ee0
Compare
mostafa
suggested changes
Sep 21, 2026
mostafa
left a comment
mostafa
left a comment
Contributor
There was a problem hiding this comment.
The bpf package split is the right direction. Makefile target paths do not match -output-dir, so make ebpf always rebuilds, and the committed objects fail the Ubuntu clang 18 drift check.
Proposed fix with regenerated objects: #734
Make looked for bindings next to the C sources, so every CI run rebuilt and failed the clang 18 drift check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
The Makefile script automates the process of compiling the eBPF programs, Fibratus binary, running tests, formatting, etc. The
bpf2gonow drops all generated Go files + ebpf bytecode inside a separate bpf package, making it easier to navigate and distinguish the generated code.What type of change does this PR introduce?
/kind improvement
Any specific area of the project related to this PR?
/area build
Special notes for the reviewer
Does this PR introduce a user-facing change?