fix(build): Point Makefile bpf targets at the generated package - #734
Merged
rabbitstack merged 1 commit intoSep 21, 2026
Conversation
Make looked for bindings next to the C sources, so every CI run rebuilt and failed the clang 18 drift check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Follow-up to #732. The Makefile declared bpf2go outputs next to the C sources while writing them under
internal/ebpf/bpf, somake ebpfalways rebuilt and CI failed the generation-drift check against Ubuntu clang 18 objects.What type of change does this PR introduce?
/kind bug-fix
Any specific area of the project related to this PR?
/area build
/area ci
Special notes for the reviewer
-output-dir internal/ebpf/bpf.make -B ebpfso checkout timestamps cannot skip regeneration.vmlinux.hlast.ubuntu-latest).make testruns the Linux package set that actually passes;go test ./...still fails on Windows-only tests.Does this PR introduce a user-facing change?
No.