Conversation
Summary: Give formatting its own GitHub CI step and preserve the same coverage in the aggregate `yarn test` command. This makes formatter failures independently visible before Metro becomes GitHub-first while leaving `yarn lint-fix` as the convenient combined fix command. ___ Differential Revision: D119662169
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119662169. |
Collaborator
|
Landed as 4967a2f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Give formatting its own GitHub CI step and preserve the same coverage in the aggregate
yarn testcommand. This makes formatter failures independently visible before Metro becomes GitHub-first while leavingyarn lint-fixas the convenient combined fix command.Differential Revision: D119662169