Skip to content

Separate formatting from lint in GitHub CI #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 1 commit into from
+4 −3
Closed

Separate formatting from lint in GitHub CI #1931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-test-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ permissions:
jobs:
run-js-checks:
runs-on: ubuntu-latest
name: "Type check, lint, smoke test"
name: "Type check, lint, format, smoke test"
steps:
- uses: actions/checkout@v7
- uses: ./.github/actions/yarn-install
- run: yarn typecheck
- run: yarn typecheck-ts
- run: yarn lint
- run: yarn format-check
- run: yarn test-smoke

test-with-coverage:
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@
"format": "prettier --write .",
"format-check": "prettier --check .",
"lint-fix": "eslint . --fix --cache && yarn format",
"lint": "eslint . --cache && yarn format-check",
"lint": "eslint . --cache",
"postpublish": "npm run cleanup-release --workspaces --if-present",
"publish": "yarn run build-clean && yarn run build && npm run prepare-release --workspaces --if-present && npm publish --workspaces",
"start": "node packages/metro/src/cli",
"test": "yarn run typecheck && yarn run lint && yarn run build && yarn run jest",
"test": "yarn run typecheck && yarn run lint && yarn run format-check && yarn run build && yarn run jest",
"test-coverage": "yarn run build && yarn run jest --coverage -i && node scripts/mapCoverage.js",
"test-smoke": "yarn start build --config packages/metro/src/integration_tests/metro.config.js TestBundle.js --out /tmp/TestBundle",
"typecheck": "flow check",
Expand Down
Loading