Fix incorrect results when probing multiple bloom filters - #24
Open
jianhongshi123 wants to merge 1 commit into
Open
Fix incorrect results when probing multiple bloom filters#24jianhongshi123 wants to merge 1 commit into
jianhongshi123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
PhysicalProbeFilterapplies multiple Bloom filters, it reuses the same selection vector for every lookup. After the firstinput.Slice, this vector is kept as the mapping from the sliced input to the original input. The next lookup produces a new selection relative to the sliced input, but writes it into the same selection vector, overwriting the previous mapping before these two selections are combined. This results in incorrect row indices and query results.This PR uses a separate selection vector for each Bloom filter lookup.