Skip to content

Fix incorrect results when probing multiple bloom filters #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jianhongshi123 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect results when probing multiple bloom filters #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/operators/physical_probe_filter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ OperatorResultType PhysicalProbeFilter::ExecuteInternal(ExecutionContext &contex
// }

// lookup directly into selection vector
result_count = bf->LookupSel(input, sel, {bound_column_indices[i]}, state.bit_vector.data());
SelectionVector newSel = SelectionVector(input.size());
result_count = bf->LookupSel(input, newSel, {bound_column_indices[i]}, state.bit_vector.data());

// early exit if no rows passed
if (result_count == 0) {
Expand All @@ -185,7 +186,7 @@ OperatorResultType PhysicalProbeFilter::ExecuteInternal(ExecutionContext &contex

// apply filter if we filtered rows
if (result_count < row_num) {
input.Slice(sel, result_count);
input.Slice(newSel, result_count);
row_num = result_count;
}
}
Expand Down
Loading