Repository navigation
Release v1.1.15 - #83
roeai-release-bot[bot] wants to merge 1 commit into
Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| def update( | ||
| self, | ||
| id: str, | ||
| name: str | None = None, | ||
| description: str | None = None, | ||
| ) -> UpdateSkillSet: |
There was a problem hiding this comment.
SkillSetsAPI.create() and update() omit knowledge_base_key_id, though both request schemas allow it. Callers cannot set, change, or clear the key through client.skill_sets; passing the keyword raises TypeError.
Add the field to openapi/wrappers.yml and regenerate the facade. Distinguish an omitted value from explicit None so callers can clear the key.
There was a problem hiding this comment.
Good catch. The facade is generated from the contract in roe-main (roe-sdk/sdk_contract.yml), so I'll add knowledge_base_key_id there for the next release instead of hand-editing this PR.
| def create_version( | ||
| self, | ||
| skill_set_id: str, | ||
| files: list[dict[str, Any]], | ||
| version_name: str | None = None, | ||
| base_version_id: str | None = None, | ||
| summary: str | None = None, | ||
| file_changes: list[dict[str, Any]] | None = None, | ||
| ) -> CreateSkillSetVersion: |
There was a problem hiding this comment.
The twelve new SkillSetsAPI methods have no focused tests. The existing helper test uses a fake endpoint, so it does not check the new URLs, response models, or nested version files. A change could break these workflows without a test catching it.
Add transport tests for create_version(), get_generation() with {"generation": null}, and delete or cancel errors. Check the organization query, nested JSON, returned models, and raised exceptions.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
These methods are generated from the shared contract and covered by the roe-sdk suite in roe-main, so we don't add per-language tests on release PRs.
There was a problem hiding this comment.
That makes sense. Since these facades are generated from the shared contract and the roe-sdk suite already exercises the workflows, adding per-language transport tests in a release PR would be redundant. I’ll withdraw this comment; no additional Python-specific tests are needed here.
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
|
@greptileai review |
b3ffcaa to
290100a
Compare
290100a to
fb40f3f
Compare
2 participants
This PR updates the Python SDK for release
1.1.15.Generated from:
1-1-0fd7cb2e2600482262089791471aad224ec361bad