Repository navigation
Conversation
MultiLibraryClassLoader kept every ClassLoader it created in a process-wide static vector so loaders survived while their instances were alive. Loaders whose instances outlived the MultiLibraryClassLoader stayed there until process exit, and without on-demand unloading their libraries were never unloaded. Own the loaders per MultiLibraryClassLoader instead, and have each instance hold a shared_ptr to its ClassLoader. A loader now lives exactly as long as its MultiLibraryClassLoader or its last instance, and the static vector and its destruction-order workaround go away. Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MultiLibraryClassLoaderkept itsClassLoaders in a process-wide static vector. Loaders whose instances outlived theMultiLibraryClassLoaderwere never released, so their libraries were never unloaded, and a staticMultiLibraryClassLoaderread that vector after it was destroyed at exit (part of #33).Each
MultiLibraryClassLoadernow owns its loaders asshared_ptrs, and each instance it creates holds ashared_ptrto its loader. This removes the static vector and theClassLoaderDependencyworkaround.Is this user-facing behavior change?
No API change. ABI changes, so rolling only.
Did you use Generative AI?
Claude Code (Claude Opus 5.5) wrote the change; I reviewed it.
Additional Information
Follow-up to #240. New test
MultiClassLoaderTest.instanceOutlivesLoader; its non-lazy cases fail on rolling.