Apply Ruby::Box test env workaround only when running under bundler - #1234
Merged
Merged
Conversation
The workaround added in ffaf5f1 clears RUBYOPT/RUBYLIB unconditionally. In ruby/ruby's test-bundled-gems, the spawned child needs those variables to locate the build-tree stdlib, so it failed with "cannot load such file -- prism". Clearing the bundler context is only needed when the test itself runs under bundler, where bundler/setup inherited via RUBYOPT crashes inside Ruby::Box with "uninitialized constant Gem::Specification". Restrict the workaround to that case and keep the env intact otherwise. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workaround added in ffaf5f1 clears RUBYOPT/RUBYLIB unconditionally. In ruby/ruby's test-bundled-gems, the spawned child needs those variables to locate the build-tree stdlib, so it failed with "cannot load such file -- prism".
Clearing the bundler context is only needed when the test itself runs under bundler, where bundler/setup inherited via RUBYOPT crashes inside Ruby::Box with "uninitialized constant Gem::Specification". Restrict the workaround to that case and keep the env intact otherwise.