Repository navigation
Conversation
cachebag
reviewed
Nov 5, 2026
rami3l
force-pushed
the
test/concurrent-toolchain-modification
branch
4 times, most recently
from
November 6, 2026 11:03
ee03eea to
32f2b18
Compare
rami3l
force-pushed
the
test/concurrent-toolchain-modification
branch
3 times, most recently
from
November 6, 2026 11:24
731b266 to
8d07bca
Compare
rami3l
force-pushed
the
test/concurrent-toolchain-modification
branch
from
November 6, 2026 11:25
8d07bca to
f5f28ec
Compare
…kpoints Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rami3l
force-pushed
the
test/concurrent-toolchain-modification
branch
from
November 6, 2026 15:35
f5f28ec to
5e5ecf9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of rust-lang/goals#736.
Related to #3937.
This is the first part of the real "Process Safety/Atomic Transaction" patch, in that it demonstrates where the problems really are when this feature is NOT landed.
It provides a reasonable explanation for recurring issues around #988 in its many incarnations:
Many thanks to @cachebag's testing framework, without which this would have been much more difficult.
This patch is currently in "draft" state since I am not sure if merging these tests as-is would bring any value. But in any case, the assertions in each of the tests should be flipped at the end of the feature patch.
Assisted by GitHub Copilot on Sonnet 5.5.