Skip to content

chore: refactor for unified tool results - #1723

Closed
Malte Janz (MalteJanz) wants to merge 1 commit into
mainfrom
chore/refactor-for-unified-tool-results
Closed

Malte Janz (MalteJanz) wants to merge 1 commit into
mainfrom
chore/refactor-for-unified-tool-results

Conversation

@MalteJanz

@MalteJanz Malte Janz (MalteJanz) commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Just an AI draft of the ADR implementation, will split it into concrete PRs

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.16147% with 133 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.77%. Comparing base (46703e5) to head (f4c8936).

Files with missing lines Patch % Lines
internal/verifier/rector.go 48.57% 18 Missing ⚠️
internal/verifier/storefront_twig.go 0.00% 16 Missing ⚠️
internal/verifier/prettier.go 74.50% 13 Missing ⚠️
internal/verifier/stylelint.go 77.58% 13 Missing ⚠️
internal/verifier/phpstan.go 80.00% 12 Missing ⚠️
internal/verifier/result.go 85.29% 10 Missing ⚠️
cmd/extension/extension_fix.go 0.00% 9 Missing ⚠️
internal/verifier/composer.go 69.56% 7 Missing ⚠️
cmd/extension/extension_format.go 0.00% 4 Missing ⚠️
cmd/extension/extension_validate.go 0.00% 4 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
+ Coverage   66.46%   67.77%   +1.31%     
==========================================
  Files         478      481       +3     
  Lines       32426    32418       -8     
==========================================
+ Hits        21552    21972     +420     
+ Misses      10874    10446     -428     
Flag Coverage Δ
go-test 67.77% <81.16%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MalteJanz
Malte Janz (MalteJanz) force-pushed the chore/refactor-for-unified-tool-results branch from 3f675d0 to c88bbc6 Compare October 22, 2026 14:32
@MalteJanz
Malte Janz (MalteJanz) force-pushed the chore/refactor-for-unified-tool-results branch 2 times, most recently from ce805cb to 3f4dc74 Compare October 26, 2026 10:51
Base automatically changed from chore/adr-unified-tool-results to main October 26, 2026 11:05
@MalteJanz
Malte Janz (MalteJanz) force-pushed the chore/refactor-for-unified-tool-results branch from 3f4dc74 to 49ea967 Compare October 26, 2026 11:05

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not intended to be merged!

was just an AI draft

@MalteJanz

Copy link
Copy Markdown
Contributor Author

superseded by #1731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants