Skip to content

improvement(search-mcp): log rejected tool-call fields and batched read errors - #10003

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/search-mcp-rejected-keys
Nov 13, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/search-mcp-rejected-keys

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • When a search MCP call's arguments fail the schema with unrecognized_keys, the rejection log now names the unknown fields (at most 5, each cut to 64 characters), not just the path and code
  • When a batched read_document returns an error entry for a document (a stale or altered ID, a scope change, a provider failure), the server now logs the caller-facing reason; before, only unexpected failures were logged, so a call that returned errors for every document looked like a success
  • Lets us tell a repeated client mistake apart from a new one and decide whether the existing argument repair should cover it; values are still never logged

Type of Change

  • Improvement

Testing

  • server.test.ts and server.protocol.test.ts pass
  • New tool-arguments.test.ts: fails on the old code (no keys), passes on the new
  • route-handler.test.ts passes; biome clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 13, 2026 6:14pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Adds unknown field names to rejected MCP tool-call diagnostics.

  • Rejected search calls now name unknown fields in logs.

Reviews (3) · Last reviewed commit: "improvement(search-mcp): say the logged-..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 0f9009c into staging Nov 13, 2026
80 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-mcp-rejected-keys branch November 13, 2026 18:38
@waleedlatif1 waleedlatif1 changed the title improvement(search-mcp): log the field names a rejected tool call's arguments carry improvement(search-mcp): log rejected tool-call fields and batched read errors Nov 13, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — dc3bbd82 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant