Repository navigation
improvement(search-mcp): log rejected tool-call fields and batched read errors - #10003
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds unknown field names to rejected MCP tool-call diagnostics.
Reviews (3) · Last reviewed commit: "improvement(search-mcp): say the logged-..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
unrecognized_keys, the rejection log now names the unknown fields (at most 5, each cut to 64 characters), not just the path and coderead_documentreturns an error entry for a document (a stale or altered ID, a scope change, a provider failure), the server now logs the caller-facing reason; before, only unexpected failures were logged, so a call that returned errors for every document looked like a successType of Change
Testing
server.test.tsandserver.protocol.test.tspasstool-arguments.test.ts: fails on the old code (nokeys), passes on the newroute-handler.test.tspasses; biome cleanChecklist
test-auditauthoring gate)