Repository navigation
fix(blocks): keep agent-supplied tool args that block mappers remap from dedicated fields - #10006
Merged
Merged
Conversation
…rom dedicated fields
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable new issues were found. SummaryKeeps model-supplied tool arguments when block mappers read differently named fields.
Reviews (2) · Last reviewed commit: "fix(blocks): gate every agent fallback o..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 16 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools.config.paramsmapper then runs, and its output is spread over the result. A mapper that explicitly assigns a param from a differently named dedicated subBlock therefore overwrote the model's value withundefined/null, because that subBlock is never shown in agent tool-input.(params, context)and falls back to the model's value. Where an advanced subBlock with the same id could hold a stale canvas value, the fallback is gated oncontext?.operation, which only agent calls pass (the same pattern as the Gauge block).top, updateiterationPath, commentformat.ccandbcc, send/draftimportance.timeZone.orderBy.includeSharedDrives.$filter/$search(these assignments weren't gated, so every agent call dropped the model's value) and membershiptransitive.Type of Change
Testing
blocks/blocks.test.ts.check:utils,check:test-patterns,check:comment-hygiene,check-block-registry origin/staging,check:tool-metadataandcheck:docspass.Checklist
test-auditauthoring gate)🤖 Generated with Claude Code